Problem: Filtering by start_date or end_date would fail assertion

Solution: Cast to string in date field conversion

Author: MHHukiewitz

src/aleph/sdk/query/filters.py

@@ -3,7 +3,7 @@
 
 from aleph_message.models import MessageType
 
-from ..utils import _date_field_to_float, serialize_list
+from ..utils import _date_field_to_timestamp, serialize_list
 
 
 class MessageFilter:
@@ -79,8 +79,8 @@ def as_http_params(self) -> Dict[str, str]:
             "hashes": serialize_list(self.hashes),
             "channels": serialize_list(self.channels),
             "chains": serialize_list(self.chains),
-            "startDate": _date_field_to_float(self.start_date),
-            "endDate": _date_field_to_float(self.end_date),
+            "startDate": _date_field_to_timestamp(self.start_date),
+            "endDate": _date_field_to_timestamp(self.end_date),
         }
 
         # Ensure all values are strings.
@@ -146,8 +146,8 @@ def as_http_params(self) -> Dict[str, str]:
             "hashes": serialize_list(self.hashes),
             "channels": serialize_list(self.channels),
             "chains": serialize_list(self.chains),
-            "startDate": _date_field_to_float(self.start_date),
-            "endDate": _date_field_to_float(self.end_date),
+            "startDate": _date_field_to_timestamp(self.start_date),
+            "endDate": _date_field_to_timestamp(self.end_date),
         }
 
         # Ensure all values are strings.

src/aleph/sdk/utils.py

@@ -126,12 +126,12 @@ def serialize_list(values: Optional[Iterable[str]]) -> Optional[str]:
         return None
 
 
-def _date_field_to_float(date: Optional[Union[datetime, float]]) -> Optional[float]:
+def _date_field_to_timestamp(date: Optional[Union[datetime, float]]) -> Optional[str]:
     if date is None:
         return None
     elif isinstance(date, float):
-        return date
+        return str(date)
     elif hasattr(date, "timestamp"):
-        return date.timestamp()
+        return str(date.timestamp())
     else:
         raise TypeError(f"Invalid type: `{type(date)}`")

tests/unit/test_asynchronous_get.py

@@ -1,4 +1,5 @@
 import unittest
+from datetime import datetime
 from typing import Any, Dict
 from unittest.mock import AsyncMock
 
@@ -75,6 +76,7 @@ async def test_get_posts():
             page_size=2,
             post_filter=PostFilter(
                 channels=["TEST"],
+                start_date=datetime(2021, 1, 1),
             ),
         )
 
@@ -89,6 +91,7 @@ async def test_get_messages():
             page_size=2,
             message_filter=MessageFilter(
                 message_types=[MessageType.post],
+                start_date=datetime(2021, 1, 1),
             ),
         )