Problem: Filtering by start_date or end_date would fail assertion

Solution: Allow floats to be included in HTTP params

Author: MHHukiewitz

src/aleph/sdk/query/filters.py

@@ -83,13 +83,15 @@ def as_http_params(self) -> Dict[str, str]:
             "endDate": _date_field_to_float(self.end_date),
         }
 
-        # Ensure all values are strings.
-        result: Dict[str, str] = {}
+        # Ensure all values are strings or float
+        result: Dict[str, Union[str, float]] = {}
 
         # Drop empty values
         for key, value in partial_result.items():
             if value:
-                assert isinstance(value, str), f"Value must be a string: `{value}`"
+                assert isinstance(value, str) or isinstance(
+                    value, float
+                ), f"Value must be a string or float: `{value}`"
                 result[key] = value
 
         return result
@@ -150,13 +152,15 @@ def as_http_params(self) -> Dict[str, str]:
             "endDate": _date_field_to_float(self.end_date),
         }
 
-        # Ensure all values are strings.
-        result: Dict[str, str] = {}
+        # Ensure all values are strings or float
+        result: Dict[str, Union[str, float]] = {}
 
         # Drop empty values
         for key, value in partial_result.items():
             if value:
-                assert isinstance(value, str), f"Value must be a string: `{value}`"
+                assert isinstance(value, str) or isinstance(
+                    value, float
+                ), f"Value must be a string or float: `{value}`"
                 result[key] = value
 
         return result

tests/unit/test_asynchronous_get.py

@@ -1,4 +1,5 @@
 import unittest
+from datetime import datetime
 from typing import Any, Dict
 from unittest.mock import AsyncMock
 
@@ -75,6 +76,7 @@ async def test_get_posts():
             page_size=2,
             post_filter=PostFilter(
                 channels=["TEST"],
+                start_date=datetime(2021, 1, 1),
             ),
         )
 
@@ -89,6 +91,7 @@ async def test_get_messages():
             page_size=2,
             message_filter=MessageFilter(
                 message_types=[MessageType.post],
+                start_date=datetime(2021, 1, 1),
             ),
         )