Fix: vm client sessions wasn't close + authentifications for test will use localhost as domain

Author: 1yam

tests/unit/aleph_vm_authentication.py

@@ -18,6 +18,7 @@
 
 logger = logging.getLogger(__name__)
 
+DOMAIN_NAME = "localhost"
 
 def is_token_still_valid(datestr: str):
     """
@@ -210,9 +211,9 @@ async def authenticate_jwk(request: web.Request) -> str:
     """Authenticate a request using the X-SignedPubKey and X-SignedOperation headers."""
     signed_pubkey = get_signed_pubkey(request)
     signed_operation = get_signed_operation(request)
-    if signed_pubkey.content.domain != settings.DOMAIN_NAME:
+    if signed_pubkey.content.domain != DOMAIN_NAME:
         logger.debug(
-            f"Invalid domain '{signed_pubkey.content.domain}' != '{settings.DOMAIN_NAME}'"
+            f"Invalid domain '{signed_pubkey.content.domain}' != '{DOMAIN_NAME}'"
         )
         raise web.HTTPUnauthorized(reason="Invalid domain")
     if signed_operation.content.path != request.path:
@@ -232,9 +233,9 @@ async def authenticate_websocket_message(message) -> str:
     """Authenticate a websocket message since JS cannot configure headers on WebSockets."""
     signed_pubkey = SignedPubKeyHeader.parse_obj(message["X-SignedPubKey"])
     signed_operation = SignedOperation.parse_obj(message["X-SignedOperation"])
-    if signed_pubkey.content.node_url != settings.DOMAIN_NAME:
+    if signed_pubkey.content.node_url != DOMAIN_NAME:
         logger.debug(
-            f"Invalid domain '{signed_pubkey.content.node_url}' != '{settings.DOMAIN_NAME}'"
+            f"Invalid domain '{signed_pubkey.content.node_url}' != '{DOMAIN_NAME}'"
         )
         raise web.HTTPUnauthorized(reason="Invalid domain")
     return verify_signed_operation(signed_operation, signed_pubkey)

tests/unit/test_vmclient.py

@@ -21,3 +21,4 @@ async def test_notify_allocation():
         m.post("http://localhost/control/allocation/notify", status=200)
         await vm_client.notify_allocation(vm_id=vm_id)
         assert m.requests
+        await vm_client.session.close()