Skip to content

Conversation

@1yam
Copy link
Member

@1yam 1yam commented Oct 2, 2025

This PR fix a couple of bugs / features :

Related ClickUp, GitHub or Jira tickets : ALEPH-XXX

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Failed to retrieve llama text: POST 502: Bad Gateway

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.07%. Comparing base (f1d4a5e) to head (9755979).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/pricing.py 60.60% 7 Missing and 6 partials ⚠️
src/aleph_client/commands/utils.py 50.00% 1 Missing and 2 partials ⚠️
src/aleph_client/commands/instance/__init__.py 66.66% 2 Missing ⚠️
...c/aleph_client/commands/instance/port_forwarder.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   61.23%   61.07%   -0.17%     
==========================================
  Files          20       20              
  Lines        3702     3712      +10     
  Branches      528      533       +5     
==========================================
  Hits         2267     2267              
- Misses       1162     1168       +6     
- Partials      273      277       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1yam 1yam force-pushed the 1yam-fix-cli-bugs branch from 752e95f to d1d2668 Compare October 6, 2025 14:06
@nesitor nesitor self-requested a review October 6, 2025 14:23
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@1yam 1yam force-pushed the 1yam-fix-cli-bugs branch from 95ffde2 to 9755979 Compare October 8, 2025 13:56
@nesitor nesitor merged commit e64d162 into master Oct 8, 2025
12 of 14 checks passed
@nesitor nesitor deleted the 1yam-fix-cli-bugs branch October 8, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants