-
Notifications
You must be signed in to change notification settings - Fork 15
Feat: Add Terms & Conditions #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
610963e to
4505be6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 54.32% 54.46% +0.14%
==========================================
Files 18 18
Lines 2544 2585 +41
Branches 318 326 +8
==========================================
+ Hits 1382 1408 +26
- Misses 1000 1009 +9
- Partials 162 168 +6 ☔ View full report in Codecov by Sentry. |
4505be6 to
99dcc6b
Compare
cd802fe to
62671ff
Compare
olethanh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments/nitpicks from reading the code. I haven't tested it yet.
dd97736 to
c6a1f28
Compare
c6a1f28 to
f79ea20
Compare
5adad5e to
bed45d7
Compare
bed45d7 to
552f601
Compare
Jira Tasks:
Self proofreading checklist
Changes
Add Terms & conditions feature
How to test
Create an instance on a T&C CRN, then display your instance list
TODO