Solve GPU list display issues (#316)

* Fix: Solved error messages showing the CRN list for GPUs and also added the GPU sort and filter.

* Fix: Solved code quality issues.

* Fix: Solve GPU issue on allocation

Author: nesitor

src/aleph_client/commands/instance/__init__.py

@@ -385,6 +385,10 @@ async def create(
             raise typer.Exit(1)
         if gpu:
             if crn.machine_usage and crn.machine_usage.gpu:
+                if len(crn.machine_usage.gpu.available_devices) < 1:
+                    echo("Selected CRN does not have any GPUs available.")
+                    raise typer.Exit(1)
+
                 echo("Select GPU to use:")
                 table = Table(box=box.SIMPLE_HEAVY)
                 table.add_column("Number", style="white", overflow="fold")
@@ -457,7 +461,7 @@ async def create(
 
         # Instances that need to be started by notifying a specific CRN
         crn_url = crn.url if crn and crn.url else None
-        if crn and (is_stream or confidential):
+        if crn and (is_stream or confidential or gpu):
             if not crn_url:
                 # Not the ideal solution
                 logger.debug(f"Cannot allocate {item_hash}: no CRN url")

src/aleph_client/commands/instance/display.py

@@ -31,14 +31,16 @@ class CRNTable(App[CRNInfo]):
     only_reward_address: bool = False
     only_qemu: bool = False
     only_confidentials: bool = False
+    only_gpu: bool = False
     current_sorts: set = set()
     BINDINGS = [
         ("s", "sort_by_score", "Sort By Score"),
         ("n", "sort_by_name", "Sort By Name"),
         ("v", "sort_by_version", "Sort By Version"),
         ("a", "sort_by_address", "Sort By Address"),
         ("c", "sort_by_confidential", "Sort By 🔒 Confidential"),
-        ("q", "sort_by_qemu", "Sort By Qemu"),
+        ## ("q", "sort_by_qemu", "Sort By Qemu"),
+        ("g", "sort_by_gpu", "Sort By GPU"),
         ("u", "sort_by_url", "Sort By URL"),
         ("x", "quit", "Exit"),
     ]
@@ -128,6 +130,7 @@ async def fetch_node_info(self, node: CRNInfo):
             )
             node.qemu_support = crn_info.get("computing", {}).get("ENABLE_QEMU_SUPPORT", False)
             node.confidential_computing = crn_info.get("computing", {}).get("ENABLE_CONFIDENTIAL_COMPUTING", False)
+            node.gpu_support = crn_info.get("computing", {}).get("ENABLE_GPU_SUPPORT", False)
             node.machine_usage = crn_info.get("machine_usage")
 
             # Skip nodes without machine usage
@@ -149,7 +152,11 @@ async def fetch_node_info(self, node: CRNInfo):
                 logger.debug(f"Skipping node {node.hash}, no confidential support")
                 return
             # Skip non-gpu nodes if only-gpu is set
-            if self.only_gpu and not node.gpu_support and len(node.machine_usage.gpu.available_devices) < 1:
+            if (
+                self.only_gpu
+                and not node.gpu_support
+                and not (node.machine_usage.gpu and len(node.machine_usage.gpu.available_devices) < 1)
+            ):
                 logger.debug(f"Skipping node {node.hash}, no GPU support or without GPU available")
                 return
             self.filtered_crns += 1
@@ -220,5 +227,8 @@ def action_sort_by_confidential(self):
     def action_sort_by_qemu(self):
         self.sort_by("qemu_support")
 
+    def action_sort_by_gpu(self):
+        self.sort_by("gpu_support")
+
     def action_sort_by_url(self):
         self.sort_by("url")