Skip to content

Fix data access by field index in PgRow #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix data access by field index in PgRow #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74aaae0
Fix data access by field index in PgRow
RyanHoldren Aug 13, 2017
fe19b1b
Fix bug where errors are swallowed if the message is longer than 255 …
Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<groupId>com.github.alaisi.pgasync</groupId>
<artifactId>postgres-async-driver</artifactId>
<version>0.10-SNAPSHOT</version>
<version>0.10.ryan</version>

<name>postgres-async-driver</name>
<description>Asynchronous PostgreSQL Java driver</description>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/github/pgasync/impl/PgConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import static com.github.pgasync.impl.message.RowDescription.ColumnDescription;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -184,7 +184,7 @@ public void onCompleted() {
}

static Map<String,PgColumn> getColumns(ColumnDescription[] descriptions) {
Map<String,PgColumn> columns = new HashMap<>();
Map<String,PgColumn> columns = new LinkedHashMap<>();
for (int i = 0; i < descriptions.length; i++) {
columns.put(descriptions[i].getName().toUpperCase(), new PgColumn(i, descriptions[i].getType()));
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/github/pgasync/impl/io/ErrorResponseDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public ErrorResponse read(ByteBuffer buffer) {
String code = null;
String message = null;

byte[] field = new byte[255];
byte[] field = new byte[2048];
for (byte type = buffer.get(); type != 0; type = buffer.get()) {
String value = getCString(buffer, field);
if (type == (byte) 'S') {
Expand Down