Add unit tests for GUI and fix some small bugs (#956)

Author: ishii-norimi

.github/workflows/gh-pages.yml

@@ -33,6 +33,12 @@ jobs:
         uses: coverallsapp/github-action@master
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
+  test-js:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Test js
+        run: yarn test:js --bail
   test-gui:
     runs-on: ubuntu-latest
     steps:

.github/workflows/test.yml

@@ -18,6 +18,12 @@ jobs:
         uses: coverallsapp/github-action@master
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
+  test-js:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Test js
+        run: yarn test:js --bail
   test-gui:
     runs-on: ubuntu-latest
     steps:

.gitignore

@@ -2,4 +2,5 @@
 node_modules
 docs
 coverage
+coverage-js
 lib/**/*.d.ts

js/data/base.js

@@ -228,7 +228,7 @@ export class MultiDimensionalData extends BaseData {
 					this._originalY = this._y
 					this._y = this._y.map(v => this._output_category_names.indexOf(v) + 1)
 					if (infos[i].labels) {
-						this._output_category_names[k] = this._output_category_names[k].map(v =>
+						this._output_category_names = this._output_category_names.map(v =>
 							Object.hasOwn(infos[i].labels, v) ? infos[i].labels[v] : v
 						)
 					}

js/data/loader/csv.js

@@ -25,7 +25,7 @@ export default class CSV {
 		if (this._header > 0) {
 			return this._data[0]
 		}
-		return Array.from(this._data[0], (_, i) => i)
+		return Array.from(this._data[0], (_, i) => '' + i)
 	}
 
 	/**

js/expression.js

@@ -18,7 +18,7 @@ const uops = {
 
 const bops = {
 	'||': new OP('||', -2, (a, b) => (a || b ? 1 : 0)),
-	'&&': new OP('&&', -1, (a, b) => (a || b ? 1 : 0)),
+	'&&': new OP('&&', -1, (a, b) => (a && b ? 1 : 0)),
 	'==': new OP('==', 0, (a, b) => (a === b ? 1 : 0)),
 	'!=': new OP('!=', 0, (a, b) => (a !== b ? 1 : 0)),
 	'<': new OP('<', 0, (a, b) => (a < b ? 1 : 0)),

js/utils.js

@@ -122,7 +122,7 @@ export class EventEmitter {
 			return
 		}
 		for (let i = listeners.length - 1; i >= 0; i--) {
-			if (listeners[i] === listener) {
+			if (listeners[i].cb === listener) {
 				listeners.splice(i, 1)
 			}
 		}

package.json

@@ -20,6 +20,7 @@
     "lint": "eslint ./lib ./tests",
     "check-types": "npm run create-entry && tsc ./lib/**.js ./lib/**/*.js --allowJs --checkJs --target esnext --noEmit --skipLibCheck",
     "test:lib": "npm run create-entry && NODE_OPTIONS=--experimental-vm-modules npx jest --testMatch '**/lib/**/?(*.)+(spec|test).[jt]s?(x)' --coverage --coveragePathIgnorePatterns '/node_modules/' 'onnx/onnx_pb.js' --reporters default ./tests/retry-test.js ./tests/slow-test.js --maxWorkers=100% --workerIdleMemoryLimit=100MB",
+    "test:js": "NODE_OPTIONS=--experimental-vm-modules npx jest --config ./tests/jest-js.config.js",
     "test:gui": "NODE_OPTIONS=--experimental-vm-modules npx jest --testMatch '**/gui/**/?(*.)+(spec|test).[jt]s?(x)' --coveragePathIgnorePatterns '/node_modules/' 'onnx/onnx_pb.js' --reporters default ./tests/retry-test.js ./tests/slow-test.js ./tests/gui-coverage-reporter.js --testTimeout=20000 --maxWorkers=100% --workerIdleMemoryLimit=100MB",
     "types": "npm run create-entry && find lib -name \\*.d.ts -delete && tsc ./lib/**.js ./lib/**/*.js --declaration --allowJs --emitDeclarationOnly",
     "document": "npm run types && typedoc --skipErrorChecking ./lib/**.d.ts",

tests/jest-js.config.js

@@ -0,0 +1,15 @@
+export default {
+	testMatch: ['**/js/**/?(*.)+(spec|test).[jt]s?(x)'],
+	reporters: ['default', '<rootDir>/retry-test.js', '<rootDir>/slow-test.js'],
+	moduleNameMapper: {
+		'^https://cdn\\.jsdelivr\\.net/npm/pdfjs-dist@[0-9.]+/build/pdf\\.min\\.mjs$':
+			'<rootDir>/js/__mock__/pdf.min.js',
+		'^https://cdnjs\\.cloudflare\\.com/ajax/libs/encoding-japanese/[0-9.]+/encoding\\.min\\.js$':
+			'<rootDir>/js/__mock__/encoding.min.js',
+	},
+	collectCoverage: true,
+	coverageDirectory: '../coverage-js',
+	coveragePathIgnorePatterns: ['/node_modules/', 'onnx/onnx_pb.js'],
+	maxWorkers: '100%',
+	workerIdleMemoryLimit: '100MB',
+}

tests/js/__mock__/encoding.min.js

@@ -0,0 +1 @@
+export default {}