From 8d84dac8bdab3718d54d55a47204e30ffa336afb Mon Sep 17 00:00:00 2001
From: Anton Gilgur <agilgur5@gmail.com>
Date: Mon, 13 Jun 2022 18:16:24 -0400
Subject: [PATCH] deps: use @agilgur5/tsconfig to simplify tsconfig

- this is my own tsconfig base built on top of @tsconfig/strictest
  - as you can see, it just reduces all the non-type-checking related config that @tsconfig/strictest doesn't cover

- TS doesn't yet support package `exports` for tsconfigs yet, hence the longer path into the package

- Relative paths in tsconfig bases are also relative _within_ node_modules, so have to repeat any relative paths here
  - And due to this, I think it's better right now for `build` to extend the base here instead of the `build` tsconfig in `@agilgur5/tsconfig`
    - I didn't fully think that one through when I made it tbh, though it still serves as a good example tsconfig
    - Maybe that will be different in the future if TS changes or otherwise comes up with a solution to this
---
 package-lock.json | 26 +++++++++++++++++++++++++-
 package.json      |  2 +-
 tsconfig.json     | 18 ++----------------
 3 files changed, 28 insertions(+), 18 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 463dbb9..56a4199 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -18,6 +18,7 @@
       },
       "devDependencies": {
         "@agilgur5/changelog-maker": "^3.0.0",
+        "@agilgur5/tsconfig": "^0.0.1",
         "@babel/core": "^7.17.9",
         "@babel/plugin-transform-runtime": "^7.17.0",
         "@babel/preset-env": "^7.16.11",
@@ -28,7 +29,6 @@
         "@rollup/plugin-babel": "^5.3.1",
         "@rollup/plugin-commonjs": "^21.1.0",
         "@rollup/plugin-node-resolve": "^13.2.1",
-        "@tsconfig/strictest": "^1.0.1",
         "@types/enzyme": "^3.10.4",
         "@wojtekmaj/enzyme-adapter-react-17": "^0.6.6",
         "canvas": "^2.9.1",
@@ -112,6 +112,21 @@
         "node": ">=6"
       }
     },
+    "node_modules/@agilgur5/tsconfig": {
+      "version": "0.0.1",
+      "resolved": "https://registry.npmjs.org/@agilgur5/tsconfig/-/tsconfig-0.0.1.tgz",
+      "integrity": "sha512-Q/Rwf0DjxOh3DXnKbLauBAWuVFOWHTm1ViwlHhdGEiCv/jdwCwIJjYh9NmYmfgcGnTTDlcShHG7x2C+7Xsd9ag==",
+      "dev": true,
+      "dependencies": {
+        "@tsconfig/strictest": "^1.0.0"
+      },
+      "engines": {
+        "node": ">=12.7.0"
+      },
+      "funding": {
+        "url": "https://github.com/sponsors/agilgur5"
+      }
+    },
     "node_modules/@ampproject/remapping": {
       "version": "2.1.2",
       "resolved": "https://registry.npmjs.org/@ampproject/remapping/-/remapping-2.1.2.tgz",
@@ -14885,6 +14900,15 @@
         }
       }
     },
+    "@agilgur5/tsconfig": {
+      "version": "0.0.1",
+      "resolved": "https://registry.npmjs.org/@agilgur5/tsconfig/-/tsconfig-0.0.1.tgz",
+      "integrity": "sha512-Q/Rwf0DjxOh3DXnKbLauBAWuVFOWHTm1ViwlHhdGEiCv/jdwCwIJjYh9NmYmfgcGnTTDlcShHG7x2C+7Xsd9ag==",
+      "dev": true,
+      "requires": {
+        "@tsconfig/strictest": "^1.0.0"
+      }
+    },
     "@ampproject/remapping": {
       "version": "2.1.2",
       "resolved": "https://registry.npmjs.org/@ampproject/remapping/-/remapping-2.1.2.tgz",
diff --git a/package.json b/package.json
index f9198f0..1817170 100644
--- a/package.json
+++ b/package.json
@@ -78,6 +78,7 @@
   },
   "devDependencies": {
     "@agilgur5/changelog-maker": "^3.0.0",
+    "@agilgur5/tsconfig": "^0.0.1",
     "@babel/core": "^7.17.9",
     "@babel/plugin-transform-runtime": "^7.17.0",
     "@babel/preset-env": "^7.16.11",
@@ -88,7 +89,6 @@
     "@rollup/plugin-babel": "^5.3.1",
     "@rollup/plugin-commonjs": "^21.1.0",
     "@rollup/plugin-node-resolve": "^13.2.1",
-    "@tsconfig/strictest": "^1.0.1",
     "@types/enzyme": "^3.10.4",
     "@wojtekmaj/enzyme-adapter-react-17": "^0.6.6",
     "canvas": "^2.9.1",
diff --git a/tsconfig.json b/tsconfig.json
index a008b62..45812a8 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -1,25 +1,11 @@
 {
-  // https://github.com/tsconfig/bases
-  "extends": "@tsconfig/strictest/tsconfig.json",
+  // https://github.com/agilgur5/tsconfig
+  "extends": "@agilgur5/tsconfig/src/tsconfig.library.json",
   // exclude node_modules (the default), dist dir, coverage dir, and example for now
   "exclude": ["node_modules/", "dist/", "coverage/", "example/"],
   // see https://www.typescriptlang.org/tsconfig to better understand tsconfigs
   "compilerOptions": {
     // output to dist/ dir
     "outDir": "dist/",
-    // output .d.ts declaration files for consumers
-    "declaration": true,
-    // output .d.ts.map declaration map files for consumers
-    "declarationMap": true,
-    // output .js.map sourcemap files for consumers
-    "sourceMap": true,
-    // use Node's module resolution algorithm, instead of the legacy TS one
-    "moduleResolution": "node",
-    // resolve JSON files
-    "resolveJsonModule": true,
-    // transpile JSX to React.createElement
-    "jsx": "react",
-    // ignored during builds, but commonly used when type-checking with `tsc`
-    "noEmit": true,
   }
 }