Skip to content

Commit 7feea6e

Browse files
committed
fix: allow ActiveOverlay to manage open state
1 parent 9996dbb commit 7feea6e

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

packages/dialog/dialog-wrapper.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,7 @@ import { DialogWrapper } from '@spectrum-web-components/dialog';
3838
>
3939
Content of the dialog
4040
</sp-dialog-wrapper>
41-
<sp-button
42-
slot="trigger"
43-
variant="primary"
44-
onClick="
45-
const overlayTrigger = this.parentElement;
46-
overlayTrigger.clickContent.open = true;
47-
"
48-
>
49-
Toggle Dialog
50-
</sp-button>
41+
<sp-button slot="trigger" variant="primary">Toggle Dialog</sp-button>
5142
</overlay-trigger>
5243
```
5344

@@ -72,7 +63,6 @@ import { DialogWrapper } from '@spectrum-web-components/dialog';
7263
onClick="
7364
const overlayTrigger = this.parentElement;
7465
const dialogWrapper = overlayTrigger.clickContent;
75-
dialogWrapper.open = true;
7666
function handleEvent({type}) {
7767
spAlert(this, `<sp-dialog-wrapper> '${type}' event handled.`);
7868
dialogWrapper.open = false;

packages/popover/src/Popover.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ export class Popover extends SpectrumElement {
3535
return [popoverStyles];
3636
}
3737

38+
@property({ type: Boolean, reflect: true })
39+
public open = false;
40+
3841
/**
3942
* @type {"auto" | "auto-start" | "auto-end" | "top" | "bottom" | "right" | "left" | "top-start" | "top-end" | "bottom-start" | "bottom-end" | "right-start" | "right-end" | "left-start" | "left-end" | "none"}
4043
* @attr

packages/tooltip/src/Tooltip.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ export class Tooltip extends SpectrumElement {
3535
return [tooltipStyles];
3636
}
3737

38+
@property({ type: Boolean, reflect: true })
39+
public open = false;
40+
3841
/**
3942
* @type {"auto" | "auto-start" | "auto-end" | "top" | "bottom" | "right" | "left" | "top-start" | "top-end" | "bottom-start" | "bottom-end" | "right-start" | "right-end" | "left-start" | "left-end" | "none"}
4043
* @attr

0 commit comments

Comments
 (0)