Skip to content

Commit 2d2515f

Browse files
committed
fix: button-base simplify check
1 parent ed134ec commit 2d2515f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/button/src/ButtonBase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ export class ButtonBase extends ObserveSlotText(LikeAnchor(Focusable), '', [
241241
} else {
242242
// if dev set aria-label instead of label, don't remove it, and throw warning
243243
if (
244-
this.getAttribute('label') === null &&
244+
!this.hasAttribute('label') &&
245245
this.hasAttribute('aria-label')
246246
) {
247247
console.warn(

0 commit comments

Comments
 (0)