Merge pull request #199 from adobe/optimize

Optimize

Author: dsoffiantini

packages/optimize/README.md

@@ -175,7 +175,7 @@ This API fetches the propositions for the provided DecisionScope list.
 
 **Syntax**
 ```typescript
-updatePropositions(decisionScopes: Array<DecisionScope>, xdm: ?Map<string, any>, data: ?Map<string, any>)
+updatePropositions(decisionScopes: Array<DecisionScope>, xdm?: Map<string, any>, data?: Map<string, any>)
 ```
 
 **Example**
@@ -207,7 +207,7 @@ This class represents the decision scope which is used to fetch the decision pro
 module.exports = class DecisionScope {
     name: string;        
 
-    constructor(name: ?string, activityId: ?string, placementId: ?string, itemCount: ?number) {                
+    constructor(name?: string, activityId?: string, placementId?: string, itemCount?: number) {                
         if(name && name.trim()) {
             this.name = name;
         } else {            
@@ -239,7 +239,7 @@ module.exports = class Proposition {
     scope: string;
     scopeDetails: Map<string, any>;
 
-    constructor(eventData: any) {
+    constructor(eventData: PropositionEventData) {
         this.id = eventData['id'];
         this.scope = eventData['scope'];
         this.scopeDetails = eventData['scopeDetails'];
@@ -269,29 +269,31 @@ module.exports = class Offer {
     id: string;
     etag: string;
     schema: string;
-    data: {string: any};    
+    data: Record<string, any>;    
+    meta?: Record<string, any>;    
 
-    get content(): ?string {
+    get content(): string {
         return this.data["content"];
     }
 
-    get format(): ?string {
+    get format(): string {
         return this.data["format"];
     }
 
-    get language(): ?Array<string> {
+    get language(): Array<string> {
         return this.data["language"];
     }
 
-    get characteristics(): ?Map<string, any> {
+    get characteristics(): Map<string, any> {
         return this.data["characteristics"];
     }    
 
-    constructor(eventData: any) {
+    constructor(eventData: OfferEventData) {
         this.id = eventData['id'];
         this.etag = eventData['etag'];
         this.schema = eventData['schema'];        
         this.data = eventData['data'];
+        this.meta = eventData['meta']
     }
 
     /**

packages/optimize/__tests__/OptimizeTests.ts

@@ -75,6 +75,9 @@ describe('Optimize', () => {
     expect(offer.format).toBe('text/plain');
     expect(offer.language).toBe(offerJson.data.language);
     expect(offer.characteristics).toBe(offerJson.data.characteristics);
+    expect(offer.meta).toMatchObject({
+      "custom": "custom-meta"
+    })
   });
 
   it('Test Offer.displayed', async () => {

packages/optimize/__tests__/offer.json

@@ -10,5 +10,8 @@
     "characteristics": {
       "mobile": "true"
     }
+  },
+  "meta": {
+    "custom": "custom-meta"
   }
 }

packages/optimize/ts/models/Offer.ts

@@ -17,14 +17,16 @@ interface OfferEventData {
     id: string;
     etag: string;
     schema: string;
-    data: Record<string, any>;   
+    data: Record<string, any>;  
+    meta?: Record<string, any>; 
 }
 
 class Offer {
     id: string;
     etag: string;
     schema: string;
-    data: Record<string, any>;    
+    data: Record<string, any>;  
+    meta?: Record<string, any>;  
 
     get content(): string {
         return this.data["content"];
@@ -47,6 +49,7 @@ class Offer {
         this.etag = eventData['etag'];
         this.schema = eventData['schema'];        
         this.data = eventData['data'];
+        this.meta = eventData['meta'];
     }
 
     /**