Skip to content

Commit 18a9aa1

Browse files
authored
Review updates (#253)
* Optimize view fixes * Fixed issue with setting Places authorization status * Fixed Places auth status enum string inconsistencies between ts and bridge files
1 parent c6a0b96 commit 18a9aa1

File tree

3 files changed

+12
-25
lines changed

3 files changed

+12
-25
lines changed

apps/AEPSampleApp/extensions/OptimizeView.tsx

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const ViewTypes = {
3333
content: 1,
3434
};
3535

36-
const TARGET_OFFER_TYPE_TEXT = 'text/plain';
3736
const TARGET_OFFER_TYPE_JSON = 'application/json';
3837
const TARGET_OFFER_TYPE_HTML = 'text/html';
3938

@@ -113,26 +112,14 @@ export default ({navigation}: any) => {
113112
setImageProposition(propositions.get(decisionScopeImage.getName()));
114113
setHtmlProposition(propositions.get(decisionScopeHtml.getName()));
115114
setJsonProposition(propositions.get(decisionScopeJson.getName()));
116-
setTargetProposition(
117-
propositions.get(decisionScopeTargetMbox.getName()),
118-
);
115+
setTargetProposition(propositions.get(decisionScopeTargetMbox.getName()));
119116
}
120117
},
121118
});
122119

123120
const renderTargetOffer = () => {
124121
if (targetProposition?.items) {
125-
if (targetProposition.items[0].format === TARGET_OFFER_TYPE_TEXT) {
126-
return (
127-
<Text
128-
style={{margin: 10, fontSize: 18}}
129-
onPress={() => {
130-
targetProposition?.items[0].tapped(targetProposition);
131-
}}>
132-
{targetProposition.items[0].content}
133-
</Text>
134-
);
135-
} else if (targetProposition.items[0].format === TARGET_OFFER_TYPE_JSON) {
122+
if (targetProposition.items[0].format === TARGET_OFFER_TYPE_JSON) {
136123
return (
137124
<Text
138125
style={{margin: 10, fontSize: 18}}

packages/places/android/src/main/java/com/adobe/marketing/mobile/reactnative/places/RCTAEPPlacesDataBridge.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ public class RCTAEPPlacesDataBridge {
2929

3030

3131
// @{link PlacesAuthorizationStatus}
32-
public final static String AEP_PLACES_AUTH_STATUS_DENIED = "AEP_PLACES_AUTH_STATUS_DENIED";
33-
public final static String AEP_PLACES_AUTH_STATUS_ALWAYS = "AEP_PLACES_AUTH_STATUS_ALWAYS";
34-
public final static String AEP_PLACES_AUTH_STATUS_UNKNOWN = "AEP_PLACES_AUTH_STATUS_UNKNOWN";
35-
public final static String AEP_PLACES_AUTH_STATUS_RESTRICTED = "AEP_PLACES_AUTH_STATUS_RESTRICTED";
36-
public final static String AEP_PLACES_AUTH_STATUS_WHEN_IN_USE = "AEP_PLACES_AUTH_STATUS_WHEN_IN_USE";
32+
public final static String AEP_PLACES_AUTH_STATUS_DENIED = "PLACES_AUTH_STATUS_DENIED";
33+
public final static String AEP_PLACES_AUTH_STATUS_ALWAYS = "PLACES_AUTH_STATUS_ALWAYS";
34+
public final static String AEP_PLACES_AUTH_STATUS_UNKNOWN = "PLACES_AUTH_STATUS_UNKNOWN";
35+
public final static String AEP_PLACES_AUTH_STATUS_RESTRICTED = "PLACES_AUTH_STATUS_RESTRICTED";
36+
public final static String AEP_PLACES_AUTH_STATUS_WHEN_IN_USE = "PLACES_AUTH_STATUS_WHEN_IN_USE";
3737

3838
// Location
3939
private final static String AEP_PLACES_LOCATION_LATITUDE = "latitude";

packages/places/ios/src/RCTAEPPlacesDataBridge.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515

1616
// @{link PlacesAuthorizationStatus}
1717
static NSString *const AEP_PLACES_AUTH_STATUS_DENIED =
18-
@"AEP_PLACES_AUTH_STATUS_DENIED";
18+
@"PLACES_AUTH_STATUS_DENIED";
1919
static NSString *const AEP_PLACES_AUTH_STATUS_ALWAYS =
20-
@"AEP_PLACES_AUTH_STATUS_ALWAYS";
20+
@"PLACES_AUTH_STATUS_ALWAYS";
2121
static NSString *const AEP_PLACES_AUTH_STATUS_UNKNOWN =
22-
@"AEP_PLACES_AUTH_STATUS_UNKNOWN";
22+
@"PLACES_AUTH_STATUS_UNKNOWN";
2323
static NSString *const AEP_PLACES_AUTH_STATUS_RESTRICTED =
24-
@"AEP_PLACES_AUTH_STATUS_RESTRICTED";
24+
@"PLACES_AUTH_STATUS_RESTRICTED";
2525
static NSString *const AEP_PLACES_AUTH_STATUS_WHEN_IN_USE =
26-
@"AEP_PLACES_AUTH_STATUS_WHEN_IN_USE";
26+
@"PLACES_AUTH_STATUS_WHEN_IN_USE";
2727

2828
// Location
2929
static NSString *const LOCATION_LATITUDE = @"latitude";

0 commit comments

Comments
 (0)