Skip to content

Advice on submitting PR for linear encoders #2815

@LearnWeaver

Description

@LearnWeaver

Hi all,
I'm a huge fan of this project. I was looking for some advice before I submit a PR.
I have a project that uses Optical Switches for determining wheel speed (and distance). I have put together a module that handles the counting via interrupts, very similar to rotaryio, however where rotaryio looks for a quadrature encoder, this module purely looks for single pulses.
My question is, how should I prepare my code for the PR. Given this linear encoder is similar to rotaryio, should I package it as a class LinearEncoder (to complement IncrementalEncoder). Or should this be put into a module like 'lineario'?

Sorry if I've not followed the process properly. First time contributing to a large open project like this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions