Attempt 2: Include mpy-cross '__init__.py' In Packages; Restructure Package Bundling #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure Package Bundling"" This reverts commit cd1a858.
This reverts commit e010f5a.
This reverts commit 495627b.
… backwards compatibility
…ild-tools into fix_arg_round_2
kattni
suggested changes
May 14, 2019
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Thanks for doing this! Two suggestions below.
|
|
||
|
|
||
| def build_bundle(libs, bundle_version, output_filename, | ||
| def build_bundle(libs, bundle_version, output_filename, pkg_folder_prefix, |
Contributor
There was a problem hiding this comment.
Let's rename this to package_folder_prefix.
| try: | ||
| build.library(library_path, build_lib_dir, mpy_cross=mpy_cross, | ||
| example_bundle=example_bundle) | ||
| build.library(library_path, build_lib_dir, pkg_folder_prefix, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt number 2; original attempt was in #31.
This version defaults
package_folder_prefixtoadafruit_, so that every .travis.yml doesn't need to be updated.