cp7 version of OnDiskBitmap usage for tilemap game #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1747
This removes the
withcontext for opening the message background image in order to lessen the changes needed for the CP7 version which can how have the filename passed to OnDiskBitmap constructor instead an open file handle.The changes shown in the github interface look more substantial than they really are since much of is un-indented from the removal of
withcontext.Tested on PyGamer with 7.0.0 alpha5
Guide: https://learn.adafruit.com/creating-your-first-tilemap-game-with-circuitpython/overview
No changes needed in the guide. The only place that references OnDiskBitmap is in the github embed.