Skip to content

Fix column offset for ssd1680 instead of ssd1675 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix column offset for ssd1680 instead of ssd1675 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4cf22
Fix column offset for ssd1680 instead of ssd1675
makermelissa Oct 2, 2023
6e602b3
Update examples to remove older style tilegrid creation
makermelissa Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adafruit_ssd1680.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class SSD1680(displayio.EPaperDisplay):

def __init__(self, bus: displayio.FourWire, **kwargs) -> None:
if "colstart" not in kwargs:
kwargs["colstart"] = 1
kwargs["colstart"] = 8
stop_sequence = bytearray(_STOP_SEQUENCE)
try:
bus.reset()
Expand Down
4 changes: 1 addition & 3 deletions examples/ssd1680_2.13_featherwing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@
with open("/display-ruler.bmp", "rb") as f:
pic = displayio.OnDiskBitmap(f)

t = displayio.TileGrid(
pic, pixel_shader=getattr(pic, "pixel_shader", displayio.ColorConverter())
)
t = displayio.TileGrid(pic, pixel_shader=pic.pixel_shader)

g.append(t)

Expand Down
4 changes: 1 addition & 3 deletions examples/ssd1680_2.13_tricolor_breakout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
with open("/display-ruler.bmp", "rb") as f:
pic = displayio.OnDiskBitmap(f)

t = displayio.TileGrid(
pic, pixel_shader=getattr(pic, "pixel_shader", displayio.ColorConverter())
)
t = displayio.TileGrid(pic, pixel_shader=pic.pixel_shader)

g.append(t)

Expand Down
9 changes: 2 additions & 7 deletions examples/ssd1680_simpletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
# For issues with display not updating top/bottom rows correctly set colstart to 8
display = adafruit_ssd1680.SSD1680(
display_bus,
colstart=1,
colstart=8,
width=250,
height=122,
busy_pin=epd_busy,
Expand All @@ -50,12 +50,7 @@

with open("/display-ruler.bmp", "rb") as f:
pic = displayio.OnDiskBitmap(f)
# CircuitPython 6 & 7 compatible
t = displayio.TileGrid(
pic, pixel_shader=getattr(pic, "pixel_shader", displayio.ColorConverter())
)
# CircuitPython 7 compatible only
# t = displayio.TileGrid(pic, pixel_shader=pic.pixel_shader)
t = displayio.TileGrid(pic, pixel_shader=pic.pixel_shader)
g.append(t)

display.show(g)
Expand Down