Fix column offset for ssd1680 instead of ssd1675 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 10, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.26 from 1.1.25: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#25 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#20 from makermelissa/bonnet-example > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#19 from makermelissa/fix-offset Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.4.2 from 4.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#70 from michalpokusa/asyncio-examples Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9 changed the column offset from 8 to 1 in order to "fix" #5. However, in hindsight, I realize the user was likely using the incorrect driver (for example SSD1675 displays appear shifted like in #5). I have tested this fix on known SSD1680 tri-color displays as well as SSD1680 monochrome displays and it fixes the shift.