Skip to content

SHA_test_sign_verify fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

SHA_test_sign_verify fix #14

merged 1 commit into from
Aug 7, 2020

Conversation

@evaherrada
Copy link
Collaborator

@evaherrada evaherrada commented Aug 7, 2020

This fixes the errors we were getting when running rsa_tests.py

@evaherrada evaherrada requested a review from brentru August 7, 2020 18:09
@evaherrada
Copy link
Collaborator Author

evaherrada commented Aug 7, 2020

Don't merge this until after #12 is merged.

Fixes #13

@evaherrada evaherrada linked an issue Aug 7, 2020 that may be closed by this pull request
VerificationError: Verification failed #13
Closed
@evaherrada
Copy link
Collaborator Author

evaherrada commented Aug 7, 2020

rsa_tests.py output:

code.py output:
Testing: <function test_encrypt_decrypt at 0x20002d70>
46.187: DEBUG - find_p_q(128): Finding p
47.419: DEBUG - find_p_q(128): Finding q
OK!
Testing: <function test_mod_msg at 0x20002db0>
51.962: DEBUG - find_p_q(128): Finding p
55.209: DEBUG - find_p_q(128): Finding q
OK!
Testing: <function test_randomness at 0x20002dc0>
61.16: DEBUG - find_p_q(128): Finding p
66.868: DEBUG - find_p_q(128): Finding q
OK!
Testing: <function test_sign_verify_sha256 at 0x20002de0>
69.839: DEBUG - find_p_q(248): Finding p
72.405: DEBUG - find_p_q(248): Finding q
OK!
Testing: <function test_sign_verify_sha384 at 0x20002e30>
98.327: DEBUG - find_p_q(312): Finding p
105.702: DEBUG - find_p_q(312): Finding q
OK!
Testing: <function test_sign_verify_sha512 at 0x20002e90>
116.92: DEBUG - find_p_q(376): Finding p
130.951: DEBUG - find_p_q(376): Finding q
OK!
Ran 6 tests in 104.11 seconds

brentru
brentru approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brentru brentru merged commit 88c1c06 into master Aug 7, 2020
@evaherrada evaherrada deleted the sha_fix branch August 7, 2020 20:37
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 11, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@fddc0fa)
84afbd0 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#12 from FoamyGuy/fix_for_board_without_display

Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#14 from adafruit/sha_fix
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#12 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_MatrixPortal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brentru brentru brentru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VerificationError: Verification failed

3 participants

@evaherrada @brentru