get_local_time improvements #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Mar 16, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 16, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#21 from makermelissa/time_improvements > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#20 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16. This adds a couple goodies. get_strftime allows users to pass a custom format to the strftime service. To make it easier for users, I added a very basic url_encode function that will convert special characters to url friendly ones. We can add to it later, but I wanted to keep memory usage minimal.
I converted get_local_time to make use of this function so users can continue to use it without breaking anything.