Skip to content

wrap the last exception when reporting repeated connect failures #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2022
Merged

wrap the last exception when reporting repeated connect failures #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa8a33f
wrap the last exception when reporting connect failure
vladak Aug 18, 2022
4c16b42
fix pylint
vladak Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions adafruit_minimqtt/adafruit_minimqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ def _get_connect_socket(self, host, port, *, timeout=1):

sock = None
retry_count = 0
last_exception = None
while retry_count < 5 and sock is None:
retry_count += 1

Expand All @@ -274,14 +275,19 @@ def _get_connect_socket(self, host, port, *, timeout=1):

try:
sock.connect((connect_host, port))
except MemoryError:
except MemoryError as exc:
sock.close()
sock = None
except OSError:
last_exception = exc
except OSError as exc:
sock.close()
sock = None
last_exception = exc

if sock is None:
if last_exception:
raise RuntimeError("Repeated socket failures") from last_exception

raise RuntimeError("Repeated socket failures")

self._backwards_compatible_sock = not hasattr(sock, "recv_into")
Expand Down