Add MP3 playback and example with files. #25
Conversation
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
thank you! There are a few things that I wondered about.
| @@ -0,0 +1,3 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2021 Kattni Rembor for Adafruit Industries | |||
There was a problem hiding this comment.
Should this be Copyright Bartlebeats instead? (presumably the same for all tracks)
There was a problem hiding this comment.
I was wondering the same thing. Wasn't sure about who to add here. Good call.
| int(255 / 12) * key_event.key_number | ||
| ) | ||
| # If adding more MP3 files, add the appropriate key numbers to the tuple below. | ||
| if key_event.key_number in (0, 1, 2, 3): |
There was a problem hiding this comment.
maybe if key_event.key_number < len(audio_files): so that there's no need to keep things in synch
There was a problem hiding this comment.
This works! Updated!
| @@ -0,0 +1,32 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2021 Kattni Rembor for Adafruit Industries | |||
There was a problem hiding this comment.
should this file be examples/macropad_mp3/code.py? I am not sure about the new rules.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
For library code, Bundlefly automatically changes the file to code.py so that the files can continue to stay within library standards and Adabot remains happy.
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.4.0 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#25 from kattni/mp3-playback
2 participants
No description provided.