Corrected position calculation after introducing breath pauses

Author: tylerwinfield

adafruit_led_animation/helper.py

@@ -323,7 +323,7 @@ def pulse_generator(period: float, animation_object, dotstar_pwm=False):
     :param dotstar_pwm: Whether to use the dostar per pixel PWM value for brightness control.
     """
     period = int((period + (animation_object.breath * 2)) * MS_PER_SECOND)
-    breath = int(animation_object.breath * MS_PER_SECOND)
+    half_breath = int(animation_object.breath * MS_PER_SECOND // 2)
     half_period = period // 2
 
     last_update = monotonic_ms()
@@ -339,12 +339,12 @@ def pulse_generator(period: float, animation_object, dotstar_pwm=False):
         last_pos = pos
         if pos > half_period:
             pos = period - pos
-        if pos < half_period and pos > (half_period - breath):
-            intensity = animation_object.max_intensity
-        elif pos > (period - breath):
+        if pos < half_breath:
             intensity = animation_object.min_intensity
+        elif pos > (half_period - half_breath):
+            intensity = animation_object.max_intensity
         else:
-            intensity = animation_object.min_intensity + ((pos / (half_period - breath)) * (animation_object.max_intensity - animation_object.min_intensity))
+            intensity = animation_object.min_intensity + (((pos - half_breath) / (half_period - (half_breath * 2))) * (animation_object.max_intensity - animation_object.min_intensity))
         if dotstar_pwm:
             fill_color = (
                 animation_object.color[0],