adding get_cell function to GridLayout #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Also may be nice to include link to the super awesome recording that shows all the steps performed. |
rsbohn
reviewed
Aug 6, 2021
Contributor
rsbohn
left a comment
rsbohn
left a comment
There was a problem hiding this comment.
Suggest using grid position in _cell_content_list instead of adding _cell_dictionary.
Me too. Thanks again for your time going over this code today @FoamyGuy ! |
|
/lgtm |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 22, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.21.0 from 2.20.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#156 from FoamyGuy/bitmap_property Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.11.0 from 1.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#46 from FoamyGuy/get_cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #43
Adding a new
get_cell()function that allows you to lookup cell content objects by their coordinates within the GridLayout. Added a new example to illustrate this functionality.