Skip to content

Support for DHT21/AM2301 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2021
Merged

Support for DHT21/AM2301 #77

merged 3 commits into from
Nov 19, 2021

Conversation

@semancik
Copy link

@semancik semancik commented Nov 17, 2021

No description provided.

tannewt
tannewt approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

tannewt
tannewt requested changes Nov 17, 2021
View reviewed changes
@semancik @tannewt
Making pylint happy
c841a69 
Co-authored-by: Scott Shawcroft <[email protected]>
@tannewt
Copy link
Member

tannewt commented Nov 18, 2021

Ah, in the three call sites you'll need to reorder the parameters so the new one is last and add max_pulses=. Here are instructions to run pre-commit (which runs pylint) locally: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit

tannewt
tannewt approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you!

@tannewt tannewt merged commit c71bdaf into adafruit:main Nov 19, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 23, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
4ccc49e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.7.0 from 3.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#77 from semancik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.12 from 5.1.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#71 from dhalbert/doc-param-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.3.2 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#43 from CedarGroveStudios/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@semancik @tannewt