Skip to content

Fix cursor centering issue #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2019
Merged

Fix cursor centering issue #10

merged 5 commits into from
Jul 22, 2019

Conversation

@brentru
Copy link
Member

@brentru brentru commented Jul 22, 2019

Addressing #4

Changes:

  • CursorManager dos not assume joystick defaults and instead reads joystick position on `init.
  • Neaten up formatting

@brentru brentru requested a review from a team July 22, 2019 16:35
glindner
glindner reviewed Jul 22, 2019
View reviewed changes
Copy link

@glindner glindner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look and run well on my PyGamer with the previous "drifting" of the joystick fixed.

@brentru
Copy link
Member Author

brentru commented Jul 22, 2019

Thanks @glindner!

@brentru brentru merged commit 2a97532 into adafruit:master Jul 22, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 23, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@1939062)
b4cfeab 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#10 from brentru/fix-cursor-centering-issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glindner glindner glindner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brentru @glindner