Update adafruit_as7341.py #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coerce new_current to between 0 and 127 to avoid wrap-around when led_current=0
Contributor
|
@DaveLangstaff Thanks for catching my bug! The failing check is from the Black formatter; please use Black to format the code and we should be good to merge This guide has info on using black: |
siddacious
suggested changes
Dec 11, 2020
Contributor
siddacious
left a comment
siddacious
left a comment
There was a problem hiding this comment.
(repeated for mandatory change request comment):
Please format with Black
|
Sorry for asking a possibly unrelated question in this PR, but I found it while trying to figure out how to turn off the LED. Will this change allow turning off the LED? I've tried this without success: |
Merged
Contributor
|
Closing. Fixed with #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coerce new_current to between 0 and 127 to avoid wrap-around when led_current=0
avoids the unexpected result of led_current=0 producing maimum brightness