Support mutually exclusive abilities (#4) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
reviewed
Aug 12, 2019
| { | ||
| PreviousAbilityTemplate = AbilityTemplateManager.FindAbilityTemplate(PrereqAbilityName); | ||
| if (PreviousAbilityTemplate != none && !Unit.HasSoldierAbility(PrereqAbilityName)) | ||
| if (InStr(PrereqAbilityName, "NOT_") == 0) |
Member
There was a problem hiding this comment.
Suggested change
| if (InStr(PrereqAbilityName, "NOT_") == 0) | |
| if (InStr(PrereqAbilityName, "NOT_", , true) == 0) |
Plain InStr on coerced names is bad because names are supposed to be case insensitive. true as the fourth function argument fixes this by making InStr case insensitive. I realize the Highlander also doesn't do this; can you tack on the change to X2CommunityCore/X2WOTCCommunityHighlander#601 ?
Author
There was a problem hiding this comment.
@robojumper Is the Repl() below also case sensitive? Perhaps it would be better to use Mid() to remove the first 4 characters, since we've already checked it starts with "NOT_". I do wonder whether @Musashi1584 wanted to make this prefix case sensitive though.
Iridar
force-pushed
the
mutually-exclusive-abilities
branch
from
b3b2edd to
00b02c6
Compare
added 2 commits
May 16, 2021 19:17
Replace `const` with `default` so this builds.
Iridar
force-pushed
the
mutually-exclusive-abilities
branch
from
319b5f0 to
daaf5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability prerequisites that begin with "NOT_" are treated as mutually
exclusive abilities and are displayed as such in the ability preview.
This takes the pull request that Musashi sent to the original NPSBD mod
and applies it to the community version.
Implements #4.