From 4e4e26ed6e8dbc0141e792e3fc20470dd5adc380 Mon Sep 17 00:00:00 2001 From: emorozov Date: Mon, 11 Mar 2024 14:43:09 +0500 Subject: [PATCH] Change message editing method to update() --- tests/api/test_messages.py | 18 ++++++++++++++++++ webexteamssdk/api/messages.py | 11 +++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/tests/api/test_messages.py b/tests/api/test_messages.py index 590e623..0a221d3 100644 --- a/tests/api/test_messages.py +++ b/tests/api/test_messages.py @@ -355,6 +355,24 @@ def test_get_message_by_id(api, group_room_text_message): assert is_valid_message(message) +def test_update_message_by_id(api, group_room_text_message): + message = api.messages.update( + group_room_text_message.id, + roomId=group_room_text_message.roomId, + text=group_room_text_message.text+" updated!" + ) + assert is_valid_message(message) + assert message.text.endswith(" updated!") + + message = api.messages.edit( + group_room_text_message.id, + roomId=group_room_text_message.roomId, + text=group_room_text_message.text+" edited!" + ) + assert is_valid_message(message) + assert message.text.endswith(" edited!") + + def test_delete_message(api, group_room, send_group_room_message): text = create_string("Message") message = api.messages.create(group_room.id, text=text) diff --git a/webexteamssdk/api/messages.py b/webexteamssdk/api/messages.py index 479cbce..cd599ea 100644 --- a/webexteamssdk/api/messages.py +++ b/webexteamssdk/api/messages.py @@ -339,11 +339,11 @@ def delete(self, messageId): # API request self._session.delete(API_ENDPOINT + '/' + messageId) - def edit(self, messageId=None, roomId=None, text=None, markdown=None): - """Edit a message. + def update(self, messageId=None, roomId=None, text=None, markdown=None): + """Update (edit) a message. Args: - messageId(basestring): The ID of the message to be edit. + messageId(basestring): The ID of the message to be updated. roomId(basestring): The room ID. text(basestring): The message, in plain text. If `markdown` is specified this parameter may be optionally used to provide @@ -370,4 +370,7 @@ def edit(self, messageId=None, roomId=None, text=None, markdown=None): json_data = self._session.put(API_ENDPOINT + '/' + messageId, json=put_data) # Return a message object created from the response JSON data - return self._object_factory(OBJECT_TYPE, json_data) \ No newline at end of file + return self._object_factory(OBJECT_TYPE, json_data) + + # Add edit() as an alias to the update() method for backward compatibility + edit = update \ No newline at end of file