Add a prettier module-summary-mode #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjuftring
changed the title
|
I just realised that I never commented on this PR. Sorry about that! I think the functionality is subsumed by now, so I'm closing. Please feel free to reopen if you think there's something missing still. |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Packed data is not defined anywhere. We can specify SIMD as a i128 (128-bit integer). Later when specifying the SIMD instructions, we can use some "expansions" to expand i128 into the required lane shapes. Also, use v128 instead of s128, v128 is already commonly used in many places in this proposal, in the BinarySIMD.md, SIMD.md, and reference interpreter.
rossberg
pushed a commit
that referenced
this pull request
Jul 23, 2024
As discussed in #202 The JS tag was added to the JS API spec in #301, but it is not observable. This change exposes it on the WebAssembly namespace, allowing it to be imported into wasm modules. This allows wasm modules to explicitly extract the thrown JS objects as externrefs from the caught exrefs, and also to throw fresh exceptions with externref payloads that will propagate into JS and can be caught as bare JS objects not wrapped in a WebAssembly.Exception. It also places the restriction that WebAssembly.Exception objects cannot be created with the JS tag, because it would result in ambiguity or asymmetry when such objects unwind from JS into wasm and back out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to tidy up the "show module signatures" mode since it wasn't indented at all and was lacking information about the memory size and (probably more important) information about imported functions.
Since we seem to get support for the binary format in the near future, it seemed to me, that some little summarizing functionality could come in handy.
This is what its output looks like: