Skip to content

Commit ad404e9

Browse files
authored
Merge pull request #47 from steveoliver/patch-1
Tag span with laravel_action only when route exists
2 parents bb60189 + 0fcefc6 commit ad404e9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/Middleware/TraceRequests.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,10 @@ protected function tagRequestData(Span $span, Request $request): void
106106
*/
107107
protected function tagResponseData(Span $span, Request $request, $response): void
108108
{
109-
if (method_exists($request->route(), 'getActionName')) {
110-
$span->tag('laravel_action', $request->route()->getActionName());
109+
if ($route = $request->route()) {
110+
if (method_exists($route, 'getActionName')) {
111+
$span->tag('laravel_action', $route->getActionName());
112+
}
111113
}
112114

113115
$span->tag('response_status', strval($response->getStatusCode()));
@@ -235,7 +237,7 @@ protected function hideSensitiveInput(Collection $input): Collection
235237
*/
236238
protected function isLaravelRoute($route): bool
237239
{
238-
return method_exists($route, 'uri');
240+
return $route && method_exists($route, 'uri');
239241
}
240242

241243
/**

0 commit comments

Comments
 (0)