Skip to content

fix: wrong value for buffered file size #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: wrong value for buffered file size #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions include/rusty_iterators/file_iterator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,24 +44,25 @@ class FileIterator<FIterType::Buffered>
fileLines.push_back(std::move(nextLine));
}
is.close();
ptr = fileLines.begin();
};

auto next() -> std::optional<std::string>
{
[[unlikely]] if (ptr == fileLines.size())
[[unlikely]] if (ptr == fileLines.end())
{
return std::nullopt;
}
auto line = fileLines.at(ptr);
auto line = *ptr;
ptr += 1;
return std::move(line);
}

[[nodiscard]] auto sizeHint() const -> std::optional<size_t> { return fileLines.size(); }
[[nodiscard]] auto sizeHint() const -> std::optional<size_t> { return fileLines.end() - ptr; }

private:
size_t ptr = 0;
std::vector<std::string> fileLines{};
std::vector<std::string>::iterator ptr;
};

template <>
Expand Down