Merge remote-tracking branch 'upstream/master' into setup-acttions-finish

Author: aminya

ISSUE_TEMPLATE.md

@@ -20,29 +20,31 @@ Do you want to ask a question? Are you looking for support? The Atom message boa
 
 ### Description
 
-[Description of the issue]
+<!-- High-level description of what's going wrong. Please be sure to include any stack traces that appear in the developer console or the exact text of any error notifications that are shown. -->
 
 ### Steps to Reproduce
 
-1. [First Step]
-2. [Second Step]
-3. [and so on...]
+1. <!-- First Step -->
+2. <!-- Second Step -->
+3. <!-- and so on... -->
 
 **Expected behavior:**
 
-[What did you expect to happen?]
+<!-- What did you expect to happen? -->
 
 **Actual behavior:**
 
-[What actually happened instead?]
+<!-- What actually happened instead? -->
 
 **Reproduces how often:**
 
-[What percentage of the time does this happen?]
+<!-- Roughly what percentage of the time does this happen? Is this issue an intermittent glitch or does it occur consistently? -->
 
-### Versions
+### Platform and Versions
 
-You can get this information from copy and pasting the output of `atom --version` and `apm --version` from the command line. Also, please include the OS and what version of the OS you're running.
+What OS and version of OS are you running?
+
+What version of Atom are you using? You can get this information from copy and pasting the output of `atom --version` and `apm --version` from the command line.
 
 ### Additional Information
 

PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,6 @@
 ### Requirements
 
 * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
-* Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.
 
 ### Description of the Change
 
@@ -13,70 +12,10 @@ We must be able to understand the design of your change from this description. I
 
 -->
 
-### Screenshot/Gif
+### Screenshot or Gif
 
 <!-- If the changes are visual, add a screenshot or record a Gif. This doesn't have to be updated during implementation, but after a PR is merged, a final screenshot/gif should be added. It might get used for blog posts, documentation etc. Write "N/A" if not applicable. -->
 
-### Alternate Designs
-
-<!-- Explain what other alternates were considered and why the proposed version was selected -->
-
-### Benefits
-
-<!-- What benefits will be realized by the code change? -->
-
-### Possible Drawbacks
-
-<!-- What are the possible side-effects or negative impacts of the code change? -->
-
 ### Applicable Issues
 
-<!-- Enter any applicable Issues here -->
-
-### Metrics
-
-<!-- What metrics are associated with this code change and what questions can they help us answer? Write "N/A" if not applicable. -->
-
-### Tests
-
-<!-- 
-
-How did you verify that your change has the desired effects?
-- How did you verify that all new functionality works as expected?
-- How did you verify that all changed functionality works as expected?
-- How did you verify that the change has not introduced any regressions?
-
-What unit or integration tests were (or will be) added to help protect against future regressions? 
-For manual testing, be sure to describe in detail the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and the results you observed.
-If you chose not to include a specific test, please explain why. 
-
-Write "N/A" if not applicable. 
-
--->
-
-### Documentation
-
-<!-- Describe the documentation added or improved. Write "N/A" if not applicable. -->
-
-### Release Notes
-
-<!--
-
-Please describe the changes in a single line that explains this improvement in
-terms that a user can understand.  This text will be used in Atom's release notes.
-
-If this change is not user-facing or notable enough to be included in release notes
-you may use the strings "Not applicable" or "N/A" here.
-
-Examples:
-
-- The GitHub package now allows you to add co-authors to commits.
-- Fixed an issue where the merge message did not show up in the commit message box.
-- Increased the performance of rendering diffs.
-
--->
-
-### User Experience Research (Optional)
-
-<!-- If this change would benefit from UXR, please state assumptions or hypotheses and specify if they are to be validated before or after releasing. Examples include investigating discoverability, verifying performance improvements, tracking metrics, etc. -->
-
+<!-- Cross-reference any applicable Issues here. Use "Fixes #NNN" or "Closes #NNN" syntax to automatically close linked issues on merge. -->

actions/auto-sprint/package-lock.json

@@ -8,7 +8,7 @@
   "dependencies": {
     "actions-toolkit": "2.2.0",
     "graphql": "14.5.8",
-    "node-fetch": "2.6.0",
+    "node-fetch": "2.6.1",
     "relay-compiler": "7.1.0"
   }
 }

actions/schema-up/package-lock.json

@@ -0,0 +1,46 @@
+# Installation
+
+The GitHub package is bundled as a core package within Atom. This means that you don't have to install it separately - download Atom from [the website](https://atom.io) and it's included automatically. This carries a number of benefits. For example, because it's included in the [v8 snapshot](https://flight-manual.atom.io/behind-atom/sections/how-atom-uses-chromium-snapshots/) produced during each Atom build, it boots extremely quickly and pays very little penalty for things like requiring and bootstrapping React.
+
+However! The downside of this is that it can take a while for new work in this repository to make its way into your editor. Here's the full lifecycle of a change:
+
+1. First, the change is done via a pull request to this repository. When it's ready and has full, passing test coverage, it's merged into the default branch.
+2. Periodically, we tag and publish batches of changes as new versions to [apm](https://atom.io/packages/github). Typically, this is done after a major bugfix or new feature is merged, or after merging a security-related dependency update.
+3. Next, we send a pull request to [the core atom repository](https://github.com/atom/atom) to bump the versions of the GitHub package dependency in its `package.json` and `package-lock.json` files. When that pull request has a green build, we merge it.
+4. The next night that the [Atom core nightly build](https://github.visualstudio.com/Atom/_build?definitionId=1) is successful, the new package version is released to the [Atom nightly channel](https://atom.io/nightly).
+5. The core Atom team regularly "rolls the railcars" to tag new release. The first time that this happens after the GitHub package dependency bump is merged, it will be included on the next release of the [Atom beta channel](https://atom.io/beta).
+6. The next time that the core Atom team "rolls the railcars" after that, the new GitHub package version is shipped to [Atom stable](https://atom.io/). :rocket: :tada:
+
+Depending on the timing, all of this can take a month and a half to two months, so when you see a pull request get merged and your issue closed, you might think you're out of luck and you'll just have to wait... but, you have a few other options here.
+
+## Use a non-stable Atom channel
+
+Instead of living at the end of the line way out on stable, you could switch to the beta or nightly channels of Atom releases.
+
+* The [beta channel](https://atom.io/beta) updates a little more frequently than the stable channel, but it's about a month ahead. This means that you'll have access to GitHub package work as soon as the next time the railcars are rolled (step 5 up above) - about a month sooner than you would if you stayed on stable.
+* The [nightly channel](https://atom.io/nightly) is updated about daily with the latest and greatest Atom build, including everything that was merged into Atom core up to that point. If you use the nightly channel, you'll have access to GitHub package work as soon as it's published in a release and merged into Atom core (step 4 up above).
+
+### Benefits
+
+By using a "fresher" Atom channel, you'll have access to features and bug-fixes much sooner than you will if you use a stable build. Despite the names, our beta and nightly channels are pretty stable... I've (@smashwilson) personally been using a nightly build for my day to day editing for years now.
+
+What's more, if you _do_ experience a serious regression - with the GitHub package or any other core behavior - you can:
+
+* File an issue to let us know, then:
+* Switch to the next channel (from nightly to beta, or beta to stable).
+
+That gives us a chance to respond to the issue, determine if it's serious enough to warrant delaying a release for if we can't fix it in time, and could prevent an order of magnitude more users from encountering the same problem... _and_ gives you a route to _immediately_ revert to an Atom version that unblocks you!
+
+## Live on the edge
+
+If you're using nightly builds, you can have access to fixes and improvements (often) within a few weeks to a month. But, it can take me some time to tag releases and get them into Atom core sometimes. If you're really can't wait, and you want to live on the very, very edge, you can run the absolute latest code as soon as it's merged.
+
+1. First, install Atom's build requirements. You don't have to clone, bootstrap and build all of Atom to do this - just install the packages and dependencies listed in the "Building" section on [the flight manual documentation](https://flight-manual.atom.io/hacking-atom/sections/hacking-on-atom-core/) for your operating system.
+2. Second, run the following command at your terminal or command line prompt:
+   ```
+   apm install atom/github
+   ```
+
+Now you'll be running everything as soon as it's merged... and `apm` will automatically keep it that way, as we merge more work!
+
+:warning: Be aware! Using this method _will_ have noticeably degrade Atom's startup time. It's especially impactful the first time you launch Atom after each update, because Atom will be transpiling all of the package source. After that, you'll essentially be missing out on the benefits of having it included in the v8 snapshot.

actions/schema-up/package.json

@@ -0,0 +1,27 @@
+# Troubleshooting guide
+
+So, you're having a problem with this package, and you're not sure what's going on. Here are a few tools that you can use to collect more information on your problem to help us help you faster.
+
+The more debugging information you can provide, the easier it will be for us to figure out what's going on, even if your problem is triggered by some configuration or local state on your machine... and the more likely it will be that we'll be able to help you out.
+
+## Atom debugging guide
+
+Be sure to look over the [Atom debugging guide](https://flight-manual.atom.io/hacking-atom/sections/debugging/), as everything written there also applies here.
+
+Take special note of the [section on the developer tools](https://flight-manual.atom.io/hacking-atom/sections/debugging/#check-for-errors-in-the-developer-tools). Any time that the package "crashes" (git and GitHub status bar buttons vanish, tabs go blank, commands are no longer present in the command palette) there's almost certainly a stack trace waiting for you in the developer tools. Copy and paste that into your issue within a triple-backtick code block and it will give us worlds more information about what's going on. For many problems, having a stack trace to work with almost single-handedly makes the difference between us not being able to do anything and us being able to land a fix.
+
+## Git diagnostics
+
+If your problem is related to specific git operations or interactions - like problems committing, pushing, or fetching - then it can be very helpful to collect git command diagnostics.
+
+To enable git diagnostic collection:
+
+* Open your [Settings tab](https://flight-manual.atom.io/getting-started/sections/atom-basics/#settings-and-preferences).
+* Navigate to the "Packages" section on the lefthand side.
+* Search for "github" in the search box.
+* Click "settings" on the "github" package result.
+* Check the checkbox labelled "Git diagnostics".
+
+Now, reproduce your problem. Every git command that's executed by this package will be logged to the developer console, including input, stdout and stderr, and exit codes, with full verbose tracing. Expand the collapsed sections corresponding to the relevant commands and copy-and-paste the results in your issue.
+
+:warning: While the git logging will elide things like passphrases for you, you may wish to manually remove references to usernames, paths, or repository URLs if you wish, for privacy reasons.