Bug fix: Mouse-over text for mage abilities is blank [GOMPS-372] #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text-fields for these abilities just got wiped somewhere along the way. I've filled in basic descriptor text. Also fixed rogue base attack, which was similarly missing text.
SamuelBellomo
added
the
1-Needs Review
Contributor
fernando-cortez
left a comment
fernando-cortez
left a comment
There was a problem hiding this comment.
For all descriptions: do a pass and add ending punctuation. Rogue sneak ability needs to be more assertive in what it does.
fernando-cortez
added
2-Reviewed with Comments
…way) Removed sentence that said the tank's shield-aura protects other nearby players
Contributor
Author
|
Okay, added missing punctuation and revised a few to be accurate. |
fernando-cortez
approved these changes
Mar 23, 2021
fernando-cortez
added
2-One More Review
pdeschain
approved these changes
Mar 23, 2021
pdeschain
added
3-Good to Merge
and removed
2-One More Review
Contributor
Author
|
I'm not authorized to merge in this branch. @fernando-cortez can you please do the honors? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text-fields for mage abilities just got wiped out somewhere along the way. I've filled in basic descriptor text. Also fixed rogue base attack, which was similarly missing text.