removed GC allocs inside of AIBrain

Author: fernando-cortez

Assets/BossRoom/Scripts/Server/Game/Character/AIBrain.cs

@@ -17,6 +17,8 @@ private enum AIStateType
             IDLE,
         }
 
+        static readonly AIStateType[] k_AIStates = { AIStateType.ATTACK , AIStateType.IDLE};
+
         private ServerCharacter m_ServerCharacter;
         private ActionPlayer m_ActionPlayer;
         private AIStateType m_CurrentState;
@@ -53,7 +55,7 @@ public void Update()
         }
 
         /// <summary>
-        /// Called when we received some HP. Positive HP is healing, negative is damage. 
+        /// Called when we received some HP. Positive HP is healing, negative is damage.
         /// </summary>
         /// <param name="inflicter">The person who hurt or healed us. May be null. </param>
         /// <param name="amount">The amount of HP received. Negative is damage. </param>
@@ -69,13 +71,15 @@ private AIStateType FindBestEligibleAIState()
         {
             // for now we assume the AI states are in order of appropriateness,
             // which may be nonsensical when there are more states
-            foreach (AIStateType type in Enum.GetValues(typeof(AIStateType)))
+            for (int i = 0; i < k_AIStates.Length; i++)
             {
-                if (m_Logics[type].IsEligible())
+                var aiState = k_AIStates[i];
+                if (m_Logics[aiState].IsEligible())
                 {
-                    return type;
+                    return aiState;
                 }
             }
+
             Debug.LogError("No AI states are valid!?!");
             return AIStateType.IDLE;
         }
@@ -115,7 +119,13 @@ public void Hate(ServerCharacter character)
         public List<ServerCharacter> GetHatedEnemies()
         {
             // first we clean the list -- remove any enemies that have disappeared (became null), are dead, etc.
-            m_HatedEnemies.RemoveAll(enemy => !IsAppropriateFoe(enemy));
+            for (int i = m_HatedEnemies.Count - 1; i >= 0; i--)
+            {
+                if (!IsAppropriateFoe(m_HatedEnemies[i]))
+                {
+                    m_HatedEnemies.RemoveAt(i);
+                }
+            }
             return m_HatedEnemies;
         }