fix: fix the no fire sound problem (external PR #138) (#148)

* fix the no fire sound problem (#138)

Co-authored-by: Fernando Cortez <[email protected]>

* changelog addition

---------

Co-authored-by: Zhanyu Feng <[email protected]>

Author: fernando-cortez

Basic/2DSpaceShooter/Assets/Scripts/ShipControl.cs

@@ -193,8 +193,7 @@ public void TakeDamage(int amount)
 
     void Fire(Vector3 direction)
     {
-        fireSound.Play();
-
+        PlayFireSoundClientRpc();
         var damage = 5;
         if (QuadDamageTimer.Value > NetworkManager.ServerTime.TimeAsFloat)
         {
@@ -498,6 +497,13 @@ void OnCollisionEnter2D(Collision2D other)
         }
     }
 
+    // --- ClientRPCs ---
+    
+    [ClientRpc]
+    void PlayFireSoundClientRpc()
+    {
+        fireSound.Play();
+    }
     // --- ServerRPCs ---
 
     [ServerRpc]

CHANGELOG.md

@@ -16,6 +16,7 @@
 ### Fixed
 - Corrected the variables used for initialization of Health and Energy (#150)
 - Converted unnecessary ship thrust NetworkVariable to a float (#149)
+- Fixed non-host clients not hearing the Fire SFX (#148)
 
 ### Client Driven