Use iteration interface of DynamicHMC #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
==========================================
+ Coverage 68.04% 69.00% +0.96%
==========================================
Files 24 24
Lines 1333 1326 -7
==========================================
+ Hits 907 915 +8
+ Misses 426 411 -15
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 439939903
💛 - Coveralls |
cpfiffer
approved these changes
Dec 23, 2020
Member
cpfiffer
left a comment
cpfiffer
left a comment
There was a problem hiding this comment.
Looks good to me. I left two comments that are more cosmetic, feel free to address them or not before merge.
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1186. It makes use of the (inofficial) iteration interface of DynamicHMC to exploit more features of AbstractMCMC and enable Gibbs sampling.