From 8e594231699499c11062e9bc6c1ff592d0519546 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Wed, 29 Apr 2020 15:10:02 +0200 Subject: [PATCH 1/3] Try some expressions --- .github/workflows/Testing.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/Testing.yaml b/.github/workflows/Testing.yaml index ab9e46b9..6c58ba29 100644 --- a/.github/workflows/Testing.yaml +++ b/.github/workflows/Testing.yaml @@ -11,7 +11,9 @@ on: jobs: test: runs-on: ${{ matrix.os }} + continue-on-error: ${{ startsWith(matrix.version, 'nightly') }} strategy: + fail-fast: false matrix: version: - '1.0' From 703ee9f647e53c2c78173d33b2889012d05f0b6b Mon Sep 17 00:00:00 2001 From: David Widmann Date: Wed, 29 Apr 2020 15:17:41 +0200 Subject: [PATCH 2/3] Check if equality works as well --- .github/workflows/Testing.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Testing.yaml b/.github/workflows/Testing.yaml index 6c58ba29..0f9914f5 100644 --- a/.github/workflows/Testing.yaml +++ b/.github/workflows/Testing.yaml @@ -11,7 +11,7 @@ on: jobs: test: runs-on: ${{ matrix.os }} - continue-on-error: ${{ startsWith(matrix.version, 'nightly') }} + continue-on-error: ${{ matrix.version == 'nightly' }} strategy: fail-fast: false matrix: From 3267a1b76482bf2d7034a090cbe54e2f772ba737 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Wed, 29 Apr 2020 15:21:50 +0200 Subject: [PATCH 3/3] Do we need fail-fast? --- .github/workflows/Testing.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/Testing.yaml b/.github/workflows/Testing.yaml index 0f9914f5..4aaaf7c8 100644 --- a/.github/workflows/Testing.yaml +++ b/.github/workflows/Testing.yaml @@ -13,7 +13,6 @@ jobs: runs-on: ${{ matrix.os }} continue-on-error: ${{ matrix.version == 'nightly' }} strategy: - fail-fast: false matrix: version: - '1.0'