suggested changes to #481 #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fixed some typos in `src/model_utils.jl` (e.g. missing !, inconsistent sequence of `out`, etc), removed unused `x` from argument. 2. wrote tests in `test/model_utils.jl` 3. included the test file in `runtests.jl`
yebai
reviewed
Jul 13, 2023
yebai
approved these changes
Jul 13, 2023
Member
yebai
left a comment
yebai
left a comment
There was a problem hiding this comment.
Thanks @YongchaoHuang — good work!
Co-authored-by: Hong Ge <[email protected]>
Contributor
Author
Thanks. More complex test cases are worth thinking. |
Member
|
@torfjelde what are your thoughts on the minor improvements and tests in this PR? |
Member
|
This PR should not have been merged without my approval given that the branch it's being merged into is something that I'm working on. I just had to do a hard reset and force push because the changes had then been intermingled with changes from merging with master (also not performed by me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to #481:
src/model_utils.jl(e.g. missing !, inconsistent sequence ofout, etc), removed unusedxfrom argument.test/model_utils.jlruntests.jl