-
Notifications
You must be signed in to change notification settings - Fork 37
Improvements to TestUtils (follow-up from #360) #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
torfjelde
merged 44 commits into
tor/link-improvements
from
tor/test-utils-improvements
Jul 20, 2022
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
5d5bc88
added example_values and posterior_mean_values methods to models in T…
torfjelde 0498336
demo models in TestUtils are now a bit more complex, including constr…
torfjelde f86f264
added logprior_true_with_logabsdet_jacobian for demo models
torfjelde 0d31137
fixed mistakes in a couple of models in TestUtils
torfjelde c52630b
moved varnames method which creates iterator of leaf varnames into Te…
torfjelde fff060c
updated docstring for test_sampler_demo_models
torfjelde e21958c
renamed varnames to varname_leaves and renamed keys(model) to varname…
torfjelde 9669345
added test_sampler_on_models as a generalization of test_sampler_demo…
torfjelde 7e02735
updated docs
torfjelde a412029
added docs for TestUtils.DEMO_MODELS
torfjelde f3818c3
updated some tests
torfjelde 8b799a4
fixed docstrings
torfjelde 93cb298
fixed docstrings
torfjelde ba5852b
imprvoed docstring
torfjelde 328f713
improved docstrings
torfjelde 8b6b440
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 5843699
fixed tests of pointwise_loglikelihoods
torfjelde 0b20f09
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 2b1893c
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 912d7f8
Apply suggestions from code review
torfjelde a276e4a
renamed posterior_mean_values to posterior_mean
torfjelde 626eea2
made demo models a bit more complex, now including different observat…
torfjelde 1558924
Update docs/src/api.md
torfjelde a62c881
reduce number of method definitions by defining some useful type unio…
torfjelde 5cc195a
removed unnecessary method
torfjelde ea5a7a4
Merge branch 'tor/test-utils-improvements' of github.com:TuringLang/D…
torfjelde 702f2ff
fixed a couple of loglikelihood_true definitions
torfjelde d8f4970
style
torfjelde 56f30bc
added tests for logprior and loglikelihood computation for SimpleVarInfo
torfjelde 2eaef02
fixed implementation of logpdf_with_trans for NoDist
torfjelde 8063d1e
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 2935bde
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 78f22e1
removed unused variable
torfjelde 025a4d4
added test for transformed values for the logprior_true and loglikeli…
torfjelde a72e9b8
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde c057080
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde f5c60ae
renamed test_sampler_on_models to test_sampler
torfjelde 7149c02
Merge branch 'tor/link-improvements' into tor/test-utils-improvements
torfjelde 25f05de
updated docs
torfjelde e05fa29
share implementation of example_values
torfjelde 431664d
Apply suggestions from code review
torfjelde b3499a3
added marginal_mean_of_samples according to suggestions
torfjelde 2bd5dcd
removed example_values in favour of rand with NamedTuple
torfjelde 61a594c
updated docs
torfjelde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that currently on
#masteranything involvingNoDist+ linkedVarInfois producing incorrect results (which, AFIAK, we were unaware of) 🙃