From b98010e73b0b790086a907cc4fbc8e419d5f7e29 Mon Sep 17 00:00:00 2001
From: Ilias Tsangaris <itsangaris@evernote.com>
Date: Tue, 3 Mar 2020 16:28:04 -0800
Subject: [PATCH] Add electron 8

Fixes #1293
---
 .travis.yml  | 11 +++++++++++
 appveyor.yml | 10 ++++++++++
 2 files changed, 21 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 2976fc5f6..46b9fc39c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -130,6 +130,14 @@ matrix:
        compiler: clang
        env: NODE_VERSION="4" # node abi 46
      # electron Linux
+     - os: linux
+      compiler: clang
+      env: NODE_VERSION="8" ELECTRON_VERSION="8.0.0"
+      dist: trusty
+      addons:
+        apt:
+            sources: [ 'ubuntu-toolchain-r-test','llvm-toolchain-precise-3.5', 'gcc-multilib', 'g++-multilib', 'libsqlite3-dev:i386' ]
+            packages: [ 'clang-3.5', 'libstdc++-4.9-dev']
      - os: linux
        compiler: clang
        env: NODE_VERSION="8" ELECTRON_VERSION="7.1.0"
@@ -239,6 +247,9 @@ matrix:
             sources: [ 'ubuntu-toolchain-r-test','llvm-toolchain-precise-3.5', 'gcc-multilib', 'g++-multilib', 'libsqlite3-dev:i386' ]
             packages: [ 'clang-3.5']
      # electron MacOs
+     - os: osx
+        compiler: clang
+        env: NODE_VERSION="8" ELECTRON_VERSION="8.0.0"
      - os: osx
        compiler: clang
        env: NODE_VERSION="8" ELECTRON_VERSION="7.1.0"
diff --git a/appveyor.yml b/appveyor.yml
index d92d1a7e9..cd2c8f685 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -43,6 +43,16 @@ environment:
     - nodejs_version: 13
       platform: x86
     # electron
+    - nodejs_version: 12
+      platform: x64
+      NODE_RUNTIME: electron
+      NODE_RUNTIME_VERSION: 8.0.0
+      TOOLSET_ARGS: --dist-url=https://electronjs.org/headers
+    - nodejs_version: 12
+      platform: x86
+      NODE_RUNTIME: electron
+      NODE_RUNTIME_VERSION: 8.0.0
+      TOOLSET_ARGS: --dist-url=https://electronjs.org/headers
     - nodejs_version: 12
       platform: x64
       NODE_RUNTIME: electron