Skip to content

Fix broken mockito bump (3.12.4 -> 4.0.0) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Fix broken mockito bump (3.12.4 -> 4.0.0) #246

merged 1 commit into from
Nov 5, 2021

Conversation

@Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Nov 4, 2021

#239 Updated only one line but forgot to update this line as well

@Zabuzard
Fix broken mockito bump (3.12.4 -> 4.0.0)
4196269 
#239 Updated only one line but forgot to update this line as well
@Zabuzard Zabuzard added the dependencies Pull requests that update a dependency file label Nov 4, 2021
@Zabuzard Zabuzard self-assigned this Nov 4, 2021
@Zabuzard Zabuzard requested review from a team as code owners November 4, 2021 09:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Heatmanofurioso
Copy link
Contributor

Heatmanofurioso commented Nov 4, 2021

We should also take note of all breaking changes and deprecated APIs
https://github.com/mockito/mockito/releases

@Tais993
Copy link
Member

Tais993 commented Nov 4, 2021

They've all been deprecated for some time already, so none of our code should break.
We'll find it out if something is deprecated now.

@Zabuzard
Copy link
Member Author

Zabuzard commented Nov 4, 2021

We should also take note of all breaking changes and deprecated APIs https://github.com/mockito/mockito/releases

We already approved, tested and released this change in #239 . This PR is not about upgrading Mockito in general, it is about fixing the partial update that Dependabot shipped.

@java-coding-prodigy
Copy link
Contributor

java-coding-prodigy commented Nov 4, 2021

We should have caught that error previously, but its alright, did not harm much. Imo we should have a comment there reminding us to upgrade it at both places.

java-coding-prodigy
java-coding-prodigy requested changes Nov 4, 2021
View reviewed changes
@Zabuzard Zabuzard enabled auto-merge (rebase) November 4, 2021 17:52
@Zabuzard Zabuzard merged commit 6a70dfd into develop Nov 5, 2021
@Zabuzard Zabuzard deleted the feature/fix_mockito_4.0.0_bump branch November 5, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marko-radosavljevic marko-radosavljevic marko-radosavljevic approved these changes

@Tais993 Tais993 Tais993 approved these changes

@java-coding-prodigy java-coding-prodigy java-coding-prodigy approved these changes

Assignees

@Zabuzard Zabuzard

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zabuzard @Heatmanofurioso @Tais993 @java-coding-prodigy @marko-radosavljevic