handling error in pipeline

Author: ankitsmt211

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java

@@ -24,16 +24,15 @@
 import java.util.Optional;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Function;
-import java.util.function.Supplier;
 
 /**
  * Routine, which periodically checks all help threads and archives them if there has not been any
  * recent activity.
  */
 public final class HelpThreadAutoArchiver implements Routine {
     private static final Logger logger = LoggerFactory.getLogger(HelpThreadAutoArchiver.class);
-    private static final int SCHEDULE_MINUTES = 60;
-    private static final Duration ARCHIVE_AFTER_INACTIVITY_OF = Duration.ofHours(12);
+    private static final int SCHEDULE_MINUTES = 6;
+    private static final Duration ARCHIVE_AFTER_INACTIVITY_OF = Duration.ofSeconds(60);
 
     private final HelpSystemHelper helper;
 
@@ -48,7 +47,7 @@ public HelpThreadAutoArchiver(HelpSystemHelper helper) {
 
     @Override
     public Schedule createSchedule() {
-        return new Schedule(ScheduleMode.FIXED_RATE, 0, SCHEDULE_MINUTES, TimeUnit.MINUTES);
+        return new Schedule(ScheduleMode.FIXED_RATE, 0, SCHEDULE_MINUTES, TimeUnit.SECONDS);
     }
 
     @Override
@@ -128,18 +127,6 @@ private static boolean shouldBeArchived(MessageChannel channel, Instant archiveA
 
     private void handleArchiveFlow(ThreadChannel threadChannel, MessageEmbed embed) {
 
-        Supplier<RestAction<Void>> archiveThread =
-                () -> threadChannel.getManager().setArchived(true);
-
-        Function<Throwable, RestAction<Void>> handleFailure = error -> {
-            if (error instanceof ErrorResponseException) {
-                logger.warn(
-                        "Unknown error occurred during help thread auto archive routine, archiving thread",
-                        error);
-            }
-            return archiveThread.get();
-        };
-
         Function<Result<Member>, RestAction<Message>> sendEmbedWithMention =
                 member -> threadChannel.sendMessage(member.get().getAsMention()).addEmbeds(embed);
 
@@ -159,11 +146,12 @@ private void handleArchiveFlow(ThreadChannel threadChannel, MessageEmbed embed)
             })
             .mapToResult()
             .flatMap(sentEmbed -> {
-                if (sentEmbed.isSuccess()) {
-                    return archiveThread.get();
+                if (sentEmbed.getFailure() instanceof ErrorResponseException) {
+                    logger.warn(
+                            "Unknown error occurred during help thread auto archive routine, archiving thread",
+                            sentEmbed.getFailure());
                 }
-
-                return handleFailure.apply(sentEmbed.getFailure());
+                return threadChannel.getManager().setArchived(true);
             })
             .queue();
     }