Made GitHub cache update async and fixed cache refresh check. Fixes #1315

Author: waliamehak

application/src/main/java/org/togetherjava/tjbot/features/github/GitHubCommand.java

@@ -21,6 +21,10 @@
 import java.util.function.ToIntFunction;
 import java.util.regex.Matcher;
 import java.util.stream.Stream;
+import java.util.concurrent.CompletableFuture;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Slash command (/github-search) used to search for an issue in one of the repositories listed in
@@ -41,11 +45,12 @@ public final class GitHubCommand extends SlashCommandAdapter {
     };
 
     private static final String TITLE_OPTION = "title";
+    private static final Logger logger = LoggerFactory.getLogger(GitHubCommand.class);
 
     private final GitHubReference reference;
 
-    private Instant lastCacheUpdate;
-    private List<String> autocompleteGHIssueCache;
+    private Instant lastCacheUpdate = Instant.EPOCH;
+    private List<String> autocompleteGHIssueCache = List.of();
 
     /**
      * Constructs an instance of GitHubCommand.
@@ -66,7 +71,14 @@ public GitHubCommand(GitHubReference reference) {
         getData().addOption(OptionType.STRING, TITLE_OPTION,
                 "Title of the issue you're looking for", true, true);
 
-        updateCache();
+        CompletableFuture.runAsync(() -> {
+            try {
+                updateCache();
+            } catch (Exception e) {
+                logger.error("Unknown error updating the GitHub cache", e);
+            }
+        });
+
     }
 
     @Override
@@ -111,7 +123,7 @@ public void onAutoComplete(CommandAutoCompleteInteractionEvent event) {
             event.replyChoiceStrings(choices).queue();
         }
 
-        if (lastCacheUpdate.isAfter(Instant.now().minus(CACHE_EXPIRES_AFTER))) {
+        if (isCacheExpired()) {
             updateCache();
         }
     }
@@ -121,12 +133,20 @@ private ToIntFunction<String> suggestionScorer(String title) {
         return s -> StringDistances.editDistance(title, s.replaceFirst("\\[#\\d+] ", ""));
     }
 
+    private boolean isCacheExpired() {
+        Instant cacheExpiresAt = lastCacheUpdate.plus(CACHE_EXPIRES_AFTER);
+        return Instant.now().isAfter(cacheExpiresAt);
+    }
+
     private void updateCache() {
+        logger.debug("GitHub Autocomplete cache update started");
+
         autocompleteGHIssueCache = reference.getRepositories().stream().map(repo -> {
             try {
                 return repo.getIssues(GHIssueState.ALL);
             } catch (IOException ex) {
-                throw new UncheckedIOException(ex);
+                throw new UncheckedIOException("Error fetching issues from repo " + repo.getName(),
+                        ex);
             }
         })
             .flatMap(List::stream)
@@ -135,5 +155,8 @@ private void updateCache() {
             .toList();
 
         lastCacheUpdate = Instant.now();
+
+        logger.debug("GitHub autocomplete cache update completed successfully. Cached {} issues.",
+                autocompleteGHIssueCache.size());
     }
 }