diff --git a/other/maximum_subarray.py b/other/maximum_subarray.py index 756e009444fe..56c1e0498486 100644 --- a/other/maximum_subarray.py +++ b/other/maximum_subarray.py @@ -1,20 +1,24 @@ -def max_subarray(nums: list[int]) -> int: +from collections.abc import Iterable + + +def max_subarray_sum(nums: Iterable[int]) -> int: """ - Returns the subarray with maximum sum - >>> max_subarray([1,2,3,4,-2]) + Raises: + ValueError: when nums is empty. + + Returns the maximum possible sum amongst all non - empty subarrays + >>> max_subarray_sum([1,2,3,4,-2]) 10 - >>> max_subarray([-2,1,-3,4,-1,2,1,-5,4]) + >>> max_subarray_sum([-2,1,-3,4,-1,2,1,-5,4]) 6 """ + if not nums: + raise ValueError('Input iterable should not be empty') curr_max = ans = nums[0] - for i in range(1, len(nums)): - if curr_max >= 0: - curr_max = curr_max + nums[i] - else: - curr_max = nums[i] - + for num in nums[1:]: + curr_max = max(curr_max + num, num) ans = max(curr_max, ans) return ans @@ -23,4 +27,4 @@ def max_subarray(nums: list[int]) -> int: if __name__ == "__main__": n = int(input("Enter number of elements : ").strip()) array = list(map(int, input("\nEnter the numbers : ").strip().split()))[:n] - print(max_subarray(array)) + print(max_subarray_sum(array))