From b3454a941951d40e9c814dddbf51e943619580ee Mon Sep 17 00:00:00 2001
From: Abdeldjaouad Nusayr Medakene
 <31663979+MrGeek1337@users.noreply.github.com>
Date: Mon, 2 Nov 2020 22:03:54 +0100
Subject: [PATCH 1/2] Update caesar_cipher.py

improved for conciseness and readability
---
 ciphers/caesar_cipher.py | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/ciphers/caesar_cipher.py b/ciphers/caesar_cipher.py
index 4038919e5dde..83eea075de63 100644
--- a/ciphers/caesar_cipher.py
+++ b/ciphers/caesar_cipher.py
@@ -193,26 +193,13 @@ def brute_force(input_string: str, alphabet=None) -> dict:
     # Set default alphabet to lower and upper case english chars
     alpha = alphabet or ascii_letters
 
-    # The key during testing (will increase)
-    key = 1
-
-    # The encoded result
-    result = ""
-
     # To store data on all the combinations
     brute_force_data = {}
 
     # Cycle through each combination
-    while key <= len(alpha):
-        # Decrypt the message
-        result = decrypt(input_string, key, alpha)
-
-        # Update the data
-        brute_force_data[key] = result
-
-        # Reset result and increase the key
-        result = ""
-        key += 1
+    for key in range(1, len(alpha) + 1):
+        # Decrypt the message and store the result in the data
+        brute_force_data[key] = decrypt(input_string, key, alpha)
 
     return brute_force_data
 

From 11451eea7e0617b9ac468ea366ca159898ee689e Mon Sep 17 00:00:00 2001
From: Dhruv Manilawala <dhruvmanila@gmail.com>
Date: Thu, 10 Dec 2020 22:49:38 +0530
Subject: [PATCH 2/2] Add type hints

---
 ciphers/caesar_cipher.py | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/ciphers/caesar_cipher.py b/ciphers/caesar_cipher.py
index 83eea075de63..4b2f76c7d873 100644
--- a/ciphers/caesar_cipher.py
+++ b/ciphers/caesar_cipher.py
@@ -1,7 +1,8 @@
 from string import ascii_letters
+from typing import Dict, Optional
 
 
-def encrypt(input_string: str, key: int, alphabet=None) -> str:
+def encrypt(input_string: str, key: int, alphabet: Optional[str] = None) -> str:
     """
     encrypt
     =======
@@ -79,7 +80,7 @@ def encrypt(input_string: str, key: int, alphabet=None) -> str:
     return result
 
 
-def decrypt(input_string: str, key: int, alphabet=None) -> str:
+def decrypt(input_string: str, key: int, alphabet: Optional[str] = None) -> str:
     """
     decrypt
     =======
@@ -144,7 +145,7 @@ def decrypt(input_string: str, key: int, alphabet=None) -> str:
     return encrypt(input_string, key, alphabet)
 
 
-def brute_force(input_string: str, alphabet=None) -> dict:
+def brute_force(input_string: str, alphabet: Optional[str] = None) -> Dict[int, str]:
     """
     brute_force
     ===========
@@ -204,7 +205,7 @@ def brute_force(input_string: str, alphabet=None) -> dict:
     return brute_force_data
 
 
-def main():
+if __name__ == "__main__":
     while True:
         print(f'\n{"-" * 10}\n Menu\n{"-" * 10}')
         print(*["1.Encrypt", "2.Decrypt", "3.BruteForce", "4.Quit"], sep="\n")
@@ -235,7 +236,3 @@ def main():
         elif choice == "4":
             print("Goodbye.")
             break
-
-
-if __name__ == "__main__":
-    main()