From c37199e4102610cbe658a9be2e854164c763d557 Mon Sep 17 00:00:00 2001 From: OluwatobiAwe Date: Thu, 8 Jun 2023 17:18:41 +0100 Subject: [PATCH 1/2] TD-1871: updated page header styles for radioitem and datetime input --- .../ViewComponents/RadioListViewComponent.cs | 6 ++++-- .../ViewModels/RadiosViewModel.cs | 5 ++++- .../Shared/Components/DateInput/Default.cshtml | 16 +++------------- .../Shared/Components/RadioList/Default.cshtml | 2 +- 4 files changed, 12 insertions(+), 17 deletions(-) diff --git a/NHSUKViewComponents.Web/ViewComponents/RadioListViewComponent.cs b/NHSUKViewComponents.Web/ViewComponents/RadioListViewComponent.cs index 401abcc..7f7045d 100644 --- a/NHSUKViewComponents.Web/ViewComponents/RadioListViewComponent.cs +++ b/NHSUKViewComponents.Web/ViewComponents/RadioListViewComponent.cs @@ -17,7 +17,8 @@ public IViewComponentResult Invoke( bool required, string? requiredClientSideErrorMessage = default, string cssClass = default, - string? optionalRadio = default + string? optionalRadio = default, + bool? isPageHeading = false ) { var model = ViewData.Model; @@ -46,7 +47,8 @@ public IViewComponentResult Invoke( errorMessages, required, string.IsNullOrEmpty(requiredClientSideErrorMessage) ? null : requiredClientSideErrorMessage, - string.IsNullOrEmpty(cssClass) ? null : cssClass + string.IsNullOrEmpty(cssClass) ? null : cssClass, + isPageHeading ); return View(viewModel); diff --git a/NHSUKViewComponents.Web/ViewModels/RadiosViewModel.cs b/NHSUKViewComponents.Web/ViewModels/RadiosViewModel.cs index 9932e96..4b71805 100644 --- a/NHSUKViewComponents.Web/ViewModels/RadiosViewModel.cs +++ b/NHSUKViewComponents.Web/ViewModels/RadiosViewModel.cs @@ -14,7 +14,8 @@ public RadiosViewModel( IEnumerable errorMessages, bool required, string? requiredClientSideErrorMessage = default, - string? cssClass = default + string? cssClass = default, + bool? isPageHeading = false ) { var errorMessageList = errorMessages.ToList(); @@ -28,6 +29,7 @@ public RadiosViewModel( Required = required; RequiredClientSideErrorMessage = requiredClientSideErrorMessage; Class = cssClass; + IsPageHeading = isPageHeading; } public string AspFor { get; set; } @@ -41,6 +43,7 @@ public RadiosViewModel( public IEnumerable Radios { get; set; } public RadiosItemViewModel OptionalRadio { get; set; } + public bool? IsPageHeading { get; set; } public bool Required { get; set; } public string RequiredClientSideErrorMessage { get; set; } } diff --git a/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml b/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml index 444d561..7aafa0e 100644 --- a/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml +++ b/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml @@ -10,19 +10,9 @@
- - @if(Model.IsPageHeading.GetValueOrDefault()==true) - { -

- @Model.Label -

- } - else - { - @Model.Label - } - -
+ + @Model.Label + @if (Model.HintTextLines != null) { @foreach (var hintText in Model.HintTextLines) {
diff --git a/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml b/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml index ddce262..badec3c 100644 --- a/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml +++ b/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml @@ -11,7 +11,7 @@
- From dd723bba37316a002948d19b216d82c52d493df3 Mon Sep 17 00:00:00 2001 From: OluwatobiAwe Date: Fri, 9 Jun 2023 10:09:06 +0100 Subject: [PATCH 2/2] TD-1871: removed css class nhsuk-fieldset__heading from fieldset legend when component is set as page heading. --- .../Shared/Components/DateInput/Default.cshtml | 14 ++++++++++++-- .../Shared/Components/RadioList/Default.cshtml | 15 ++++++++++++--- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml b/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml index 7aafa0e..6322ba4 100644 --- a/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml +++ b/NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml @@ -10,9 +10,19 @@
- - @Model.Label + + @if (Model.IsPageHeading.GetValueOrDefault() == true) + { +

+ @Model.Label +

+ } + else + { + @Model.Label + }
+ @if (Model.HintTextLines != null) { @foreach (var hintText in Model.HintTextLines) {
diff --git a/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml b/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml index badec3c..b7fa72a 100644 --- a/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml +++ b/NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml @@ -11,9 +11,18 @@
- + @if (Model.IsPageHeading.GetValueOrDefault() == true) + { +

+ @Model.Label +

+ } + else + { + + }
@if (Model.HintText != null)