test(devtools): wrap getByRole queries with explicit expect statements when the returned element is not used for assertions

zorzysty · zorzysty · commit c0587ffecdcd · 2022-07-13T19:52:12.000+02:00
diff --git a/packages/react-query-devtools/src/__tests__/devtools.test.tsx b/packages/react-query-devtools/src/__tests__/devtools.test.tsx
@@ -587,7 +587,7 @@ describe('ReactQueryDevtools', () => {
     )
     expect(sortCombobox.value).toEqual(Object.keys(sortFns)[0])
 
-    screen.getByRole('button', { name: /Asc/i })
+    expect(screen.getByRole('button', { name: /Asc/i })).toBeInTheDocument()
 
     const detailsPanel = screen.queryByText(/Query Details/i)
     expect(detailsPanel).not.toBeInTheDocument()
@@ -624,7 +624,7 @@ describe('ReactQueryDevtools', () => {
     )
     expect(sortCombobox.value).toEqual(Object.keys(sortFns)[1])
 
-    screen.getByRole('button', { name: /Desc/i })
+    expect(screen.getByRole('button', { name: /Desc/i })).toBeInTheDocument()
   })
 
   it('should initialize filter value with one stored in localstorage', () => {

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,7 @@ describe('ReactQueryDevtools', () => {`
`587`	`587`	`)`
`588`	`588`	`expect(sortCombobox.value).toEqual(Object.keys(sortFns)[0])`
`589`	`589`
`590`		`- screen.getByRole('button', { name: /Asc/i })`
	`590`	`+ expect(screen.getByRole('button', { name: /Asc/i })).toBeInTheDocument()`
`591`	`591`
`592`	`592`	`const detailsPanel = screen.queryByText(/Query Details/i)`
`593`	`593`	`expect(detailsPanel).not.toBeInTheDocument()`
`@@ -624,7 +624,7 @@ describe('ReactQueryDevtools', () => {`
`624`	`624`	`)`
`625`	`625`	`expect(sortCombobox.value).toEqual(Object.keys(sortFns)[1])`
`626`	`626`
`627`		`- screen.getByRole('button', { name: /Desc/i })`
	`627`	`+ expect(screen.getByRole('button', { name: /Desc/i })).toBeInTheDocument()`
`628`	`628`	`})`
`629`	`629`
`630`	`630`	`it('should initialize filter value with one stored in localstorage', () => {`