Skip to content

Commit deb708d

Browse files
cartermpTIHan
authored andcommitted
Ti han add new line alloc fix (#5)
* Update interactivechecker and structure tests * Try to fix some legacy tests
1 parent d237a7f commit deb708d

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,17 +1531,24 @@ let x = new MyClass2(0)
15311531
[<Test>]
15321532
member public this.``AfterConstructor.5039_1``() =
15331533
AssertAutoCompleteContainsNoCoffeeBreak
1534-
[ "let someCall(x) = null"
1535-
"let xe = someCall(System.IO.StringReader()." ]
1534+
[
1535+
"""
1536+
let someCall(x) = null
1537+
let xe = someCall(System.IO.StringReader().
1538+
""" ]
15361539
"StringReader()."
15371540
[ "ReadBlock" ] // should contain (StringReader)
15381541
[ "LastIndexOfAny" ] // should not contain (String)
15391542

15401543
[<Test>]
15411544
member public this.``AfterConstructor.5039_1.CoffeeBreak``() =
15421545
AssertAutoCompleteContains
1543-
[ "let someCall(x) = null"
1544-
"let xe = someCall(System.IO.StringReader()." ]
1546+
[
1547+
"""
1548+
let someCall(x) = null
1549+
let xe = someCall(System.IO.StringReader().
1550+
"""
1551+
]
15451552
"StringReader()."
15461553
[ "ReadBlock" ] // should contain (StringReader)
15471554
[ "LastIndexOfAny" ] // should not contain (String)
@@ -4913,8 +4920,12 @@ let x = query { for bbbb in abbbbc(*D0*) do
49134920

49144921
[<Test>]
49154922
member this.``BadCompletionAfterQuicklyTyping.Bug130733.NowWorks``() =
4916-
let code = [ "let someCall(x) = null"
4917-
"let xe = someCall(System.IO.StringReader() "]
4923+
let code = [
4924+
"""
4925+
let someCall(x) = null
4926+
let xe = someCall(System.IO.StringReader()
4927+
"""
4928+
]
49184929
let (_, _, file) = this.CreateSingleFileProject(code)
49194930

49204931
TakeCoffeeBreak(this.VS)

vsintegration/tests/UnitTests/SignatureHelpProviderTests.fs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ type foo5 = N1.T<Param1=1,ParamIgnored= >
125125
("type foo5 = N1.T<Param1=1,ParamIgnored",Some ("[132..160)", 1, 2, Some "ParamIgnored"));
126126
("type foo5 = N1.T<Param1=1,ParamIgnored=",Some ("[132..160)", 1, 2, Some "ParamIgnored"))])
127127
//Test case 5
128-
( """let _ = System.DateTime(""",
128+
( """
129+
let _ = System.DateTime(
130+
""",
129131
[("let _ = System.DateTime(", Some ("[8..24)", 0, 0, None)) ])
130132
]
131133

vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@
214214
<PackageReference Include="Microsoft.VisualStudio.Threading" Version="$(MicrosoftVisualStudioThreadingPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
215215
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="$(MicrosoftVisualStudioValidationPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
216216
<PackageReference Include="NUnit" Version="$(NUnitPackageVersion)" />
217+
<PackageReference Include="NUnit3TestAdapter" Version="$(NUnitTestAdapterPackageVersion)" />
217218
<PackageReference Include="System.ValueTuple" Version="$(SystemValueTuplePackageVersion)" />
218219
<PackageReference Include="VSSDK.VSHelp" Version="$(VSSDKVSHelpPackageVersion)" />
219220
<PackageReference Include="VSSDK.VSLangProj.8" Version="$(VSSDKVSLangProj8PackageVersion)" />
@@ -242,10 +243,6 @@
242243
<PackageReference Include="Microsoft.VisualStudio.Utilities" Version="$(MicrosoftVisualStudioUtilitiesPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
243244
<PackageReference Include="Microsoft.VisualStudio.Threading" Version="$(MicrosoftVisualStudioThreadingPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
244245
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="$(MicrosoftVisualStudioValidationPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
245-
<PackageReference Include="NUnit" Version="$(NUnitPackageVersion)" />
246-
<PackageReference Include="System.ValueTuple" Version="$(SystemValueTuplePackageVersion)" />
247-
<PackageReference Include="VSSDK.VSHelp" Version="$(VSSDKVSHelpPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
248-
<PackageReference Include="VSSDK.VSLangProj.8" Version="$(VSSDKVSLangProj8PackageVersion)" PrivateAssets="all" ExcludeAssets="contentFiles;build;analyzers;native" />
249246
</ItemGroup>
250247

251248
</Project>

0 commit comments

Comments
 (0)