Skip to content

Commit cf69967

Browse files
magento-engcom-teammagento-engcom-team
authored
🔃 [EngCom] Public Pull Requests - 2.3-develop
Accepted Public Pull Requests: - magento#19419: [Newsletter] magento#19418 Cannot add additional field to system configuration at desired position (by @vasilii-b) - magento#19366: Fixing a test for Magento Newsletter. (by @tiagosampaio) - magento#19325: correct param, var and return annotation values (by @TomasVotruba) - magento#18849: Autoload for vendor root folders (by @Rus0) - magento#19455: min php version fix (by @fballiano) Fixed GitHub Issues: - magento#19418: Cannot add additional field to Newsletter system configuration at desired position (reported by @vasilii-b) has been fixed in magento#19419 by @vasilii-b in 2.3-develop branch Related commits: 1. 5937d86 - magento#17753: Magento cannot run with custom Composer vendor directories (reported by @vbuck) has been fixed in magento#18849 by @Rus0 in 2.3-develop branch Related commits: 1. 2054fab - magento#19453: wrong php version in app/bootstrap.php (reported by @fballiano) has been fixed in magento#19455 by @fballiano in 2.3-develop branch Related commits: 1. 8f22688 2. 381c3a0 3. ebce9f3
2 parents f032485 + 84e583a commit cf69967

File tree

41 files changed

+163
-109
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+163
-109
lines changed

‎app/autoload.php‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
/* 'composer install' validation */
2929
if (file_exists($vendorAutoload)) {
3030
$composerAutoloader = include $vendorAutoload;
31+
} else if (file_exists("{$vendorDir}/autoload.php")) {
32+
$vendorAutoload = "{$vendorDir}/autoload.php";
33+
$composerAutoloader = include $vendorAutoload;
3134
} else {
3235
throw new \Exception(
3336
'Vendor autoload is not found. Please run \'composer install\' under application root directory.'

‎app/bootstrap.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
#ini_set('display_errors', 1);
1212

1313
/* PHP version validation */
14-
if (!defined('PHP_VERSION_ID') || !(PHP_VERSION_ID === 70002 || PHP_VERSION_ID === 70004 || PHP_VERSION_ID >= 70006)) {
14+
if (!defined('PHP_VERSION_ID') || PHP_VERSION_ID < 70103) {
1515
if (PHP_SAPI == 'cli') {
16-
echo 'Magento supports 7.0.2, 7.0.4, and 7.0.6 or later. ' .
17-
'Please read http://devdocs.magento.com/guides/v2.2/install-gde/system-requirements.html';
16+
echo 'Magento supports PHP 7.1.3 or later. ' .
17+
'Please read https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html';
1818
} else {
1919
echo <<<HTML
2020
<div style="font:12px/1.35em arial, helvetica, sans-serif;">
21-
<p>Magento supports PHP 7.0.2, 7.0.4, and 7.0.6 or later. Please read
22-
<a target="_blank" href="http://devdocs.magento.com/guides/v2.2/install-gde/system-requirements.html">
21+
<p>Magento supports PHP 7.1.3 or later. Please read
22+
<a target="_blank" href="https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html">
2323
Magento System Requirements</a>.
2424
</div>
2525
HTML;

‎app/code/Magento/Newsletter/etc/adminhtml/system.xml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,39 +11,39 @@
1111
<label>Newsletter</label>
1212
<tab>customer</tab>
1313
<resource>Magento_Newsletter::newsletter</resource>
14-
<group id="subscription" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
14+
<group id="subscription" translate="label" type="text" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
1515
<label>Subscription Options</label>
16-
<field id="allow_guest_subscribe" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
16+
<field id="allow_guest_subscribe" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
1717
<label>Allow Guest Subscription</label>
1818
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
1919
</field>
20-
<field id="confirm" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
20+
<field id="confirm" translate="label" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
2121
<label>Need to Confirm</label>
2222
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
2323
</field>
24-
<field id="confirm_email_identity" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
24+
<field id="confirm_email_identity" translate="label" type="select" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
2525
<label>Confirmation Email Sender</label>
2626
<source_model>Magento\Config\Model\Config\Source\Email\Identity</source_model>
2727
</field>
28-
<field id="confirm_email_template" translate="label comment" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
28+
<field id="confirm_email_template" translate="label comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
2929
<label>Confirmation Email Template</label>
3030
<comment>Email template chosen based on theme fallback when "Default" option is selected.</comment>
3131
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
3232
</field>
33-
<field id="success_email_identity" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
33+
<field id="success_email_identity" translate="label" type="select" sortOrder="50" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
3434
<label>Success Email Sender</label>
3535
<source_model>Magento\Config\Model\Config\Source\Email\Identity</source_model>
3636
</field>
37-
<field id="success_email_template" translate="label comment" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
37+
<field id="success_email_template" translate="label comment" type="select" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
3838
<label>Success Email Template</label>
3939
<comment>Email template chosen based on theme fallback when "Default" option is selected.</comment>
4040
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
4141
</field>
42-
<field id="un_email_identity" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
42+
<field id="un_email_identity" translate="label" type="select" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
4343
<label>Unsubscription Email Sender</label>
4444
<source_model>Magento\Config\Model\Config\Source\Email\Identity</source_model>
4545
</field>
46-
<field id="un_email_template" translate="label comment" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
46+
<field id="un_email_template" translate="label comment" type="select" sortOrder="80" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
4747
<label>Unsubscription Email Template</label>
4848
<comment>Email template chosen based on theme fallback when "Default" option is selected.</comment>
4949
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>

‎lib/internal/Magento/Framework/Acl/Loader/ResourceLoader.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,15 @@
1212
use Magento\Framework\Acl\AclResource\ProviderInterface;
1313
use Magento\Framework\Acl\AclResourceFactory;
1414

15+
/**
16+
* ACL Loader
17+
*/
1518
class ResourceLoader implements \Magento\Framework\Acl\LoaderInterface
1619
{
1720
/**
1821
* Acl resource config
1922
*
20-
* @var ProviderInterface $resourceProvider
23+
* @var ProviderInterface
2124
*/
2225
protected $_resourceProvider;
2326

‎lib/internal/Magento/Framework/Amqp/Queue.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Queue implements QueueInterface
3737
private $envelopeFactory;
3838

3939
/**
40-
* @var LoggerInterface $logger
40+
* @var LoggerInterface
4141
*/
4242
private $logger;
4343

@@ -63,7 +63,7 @@ public function __construct(
6363
}
6464

6565
/**
66-
* {@inheritdoc}
66+
* @inheritdoc
6767
* @since 100.0.0
6868
*/
6969
public function dequeue()
@@ -98,7 +98,7 @@ public function dequeue()
9898
}
9999

100100
/**
101-
* {@inheritdoc}
101+
* @inheritdoc
102102
* @since 100.0.0
103103
*/
104104
public function acknowledge(EnvelopeInterface $envelope)
@@ -119,7 +119,7 @@ public function acknowledge(EnvelopeInterface $envelope)
119119
}
120120

121121
/**
122-
* {@inheritdoc}
122+
* @inheritdoc
123123
* @since 100.0.0
124124
*/
125125
public function subscribe($callback)
@@ -153,7 +153,7 @@ public function subscribe($callback)
153153
}
154154

155155
/**
156-
* (@inheritdoc)
156+
* @inheritdoc
157157
* @since 100.0.0
158158
*/
159159
public function reject(EnvelopeInterface $envelope, $requeue = true, $rejectionMessage = null)
@@ -172,7 +172,7 @@ public function reject(EnvelopeInterface $envelope, $requeue = true, $rejectionM
172172
}
173173

174174
/**
175-
* (@inheritdoc)
175+
* @inheritdoc
176176
* @since 100.0.0
177177
*/
178178
public function push(EnvelopeInterface $envelope)

‎lib/internal/Magento/Framework/Api/SearchCriteria/CollectionProcessor/JoinProcessor.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
use Magento\Framework\Api\SearchCriteriaInterface;
1111
use Magento\Framework\Data\Collection\AbstractDb;
1212

13+
/**
14+
* Search criteria join processor
15+
*/
1316
class JoinProcessor implements CollectionProcessorInterface
1417
{
1518
/**
@@ -28,7 +31,7 @@ class JoinProcessor implements CollectionProcessorInterface
2831
private $appliedFields = [];
2932

3033
/**
31-
* @param CustomJoinInterface[] $customFilters
34+
* @param CustomJoinInterface[] $customJoins
3235
* @param array $fieldMapping
3336
*/
3437
public function __construct(

‎lib/internal/Magento/Framework/Api/Test/Unit/ExtensionAttribute/Config/SchemaLocatorTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class SchemaLocatorTest extends \PHPUnit\Framework\TestCase
1515
*/
1616
protected $model;
1717

18-
/** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
18+
/** @var \Magento\Framework\Config\Dom\UrnResolver */
1919
protected $urnResolver;
2020

2121
protected function setUp()

‎lib/internal/Magento/Framework/App/ResourceConnection.php‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212
/**
1313
* Application provides ability to configure multiple connections to persistent storage.
14+
*
1415
* This class provides access to all these connections.
16+
*
1517
* @api
1618
*/
1719
class ResourceConnection
@@ -53,7 +55,7 @@ class ResourceConnection
5355
protected $connectionFactory;
5456

5557
/**
56-
* @var DeploymentConfig $deploymentConfig
58+
* @var DeploymentConfig
5759
*/
5860
private $deploymentConfig;
5961

‎lib/internal/Magento/Framework/App/Test/Unit/Request/HttpTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,8 @@ public function testIsAjax()
246246
}
247247

248248
/**
249-
* @param $serverVariables array
250-
* @param $expectedResult string
249+
* @param array $serverVariables
250+
* @param string $expectedResult
251251
* @dataProvider serverVariablesProvider
252252
*/
253253
public function testGetDistroBaseUrl($serverVariables, $expectedResult)
@@ -374,7 +374,7 @@ public function testIsSecure($isSecure, $serverHttps, $headerOffloadKey, $header
374374
/**
375375
* @dataProvider httpSafeMethodProvider
376376
* @backupGlobals enabled
377-
* @param string $method value of $_SERVER['REQUEST_METHOD']
377+
* @param string $httpMethod value of $_SERVER['REQUEST_METHOD']
378378
*/
379379
public function testIsSafeMethodTrue($httpMethod)
380380
{
@@ -386,7 +386,7 @@ public function testIsSafeMethodTrue($httpMethod)
386386
/**
387387
* @dataProvider httpNotSafeMethodProvider
388388
* @backupGlobals enabled
389-
* @param string $method value of $_SERVER['REQUEST_METHOD']
389+
* @param string $httpMethod value of $_SERVER['REQUEST_METHOD']
390390
*/
391391
public function testIsSafeMethodFalse($httpMethod)
392392
{

‎lib/internal/Magento/Framework/App/Test/Unit/ResourceConnection/Config/SchemaLocatorTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class SchemaLocatorTest extends \PHPUnit\Framework\TestCase
1313
*/
1414
protected $model;
1515

16-
/** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
16+
/** @var \Magento\Framework\Config\Dom\UrnResolver */
1717
protected $urnResolver;
1818

1919
protected function setUp()

0 commit comments

Comments
 (0)